Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zetaDelta := false regression #3459

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fix: zetaDelta := false regression #3459

merged 2 commits into from
Feb 22, 2024

Conversation

leodemoura
Copy link
Member

See new test. It is a mwe for an issue blocking Mathlib.

See new test. It is a mwe for an issue blocking Mathlib.
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 22, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 47595540bbcd5ef218e60e11d6586589ff3788e1 --onto 6719af350fde9339354f28d091458df39a4af9d4. (2024-02-22 15:09:30)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 22, 2024 17:25 Inactive
@leodemoura leodemoura added this pull request to the merge queue Feb 22, 2024
Merged via the queue into master with commit 53146db Feb 22, 2024
10 checks passed
@kmill
Copy link
Collaborator

kmill commented Feb 25, 2024

Just recording here that it turns out that it turns out mathlib was relying on the sources in structure instance notation introducing local instances.

We're testing out a temporary workaround to have the spread syntax introduce let bindings itself, using a special let binder that changes the kind to be an implementation detail after introducing any local instances. (Spread syntax is that {...; __ := a; __ := b} is equivalent to {a, b with ...}. It's nice because it works with where syntax.) leanprover-community/mathlib4@77711ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants