Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move BitVec to top level namespace #3451

Merged
merged 2 commits into from
Feb 23, 2024
Merged

chore: move BitVec to top level namespace #3451

merged 2 commits into from
Feb 23, 2024

Conversation

leodemoura
Copy link
Member

Motivation: Nat, Int, Fin, UInt?? are already in the top level namespace. Moreover, we will eventually define UInt?? and Int?? using BitVec.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 22, 2024 01:42 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 22, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Feb 22, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b6ed97bb3dad824d3c1fc82dbf290ef0505c42d0 --onto 6719af350fde9339354f28d091458df39a4af9d4. (2024-02-22 01:49:54)
  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 87e7c666e23e676da70c02209a8f1979f467d45d --onto 5a32473f6695b44643ef81522e892c7d7b4be8d2. (2024-02-23 21:40:39)

@leodemoura leodemoura enabled auto-merge February 22, 2024 13:59
@leodemoura
chore: move BitVec to top level namespace
3dd3cfc 
Motivation: `Nat`, `Int`, `Fin`, `UInt??` are already in the top level
namespace. We will eventually define `UInt??` and `Int??` using `BitVec`.
@leodemoura leodemoura requested a review from kim-em as a code owner February 23, 2024 22:30
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 23, 2024 22:39 Inactive
@leodemoura leodemoura added this pull request to the merge queue Feb 23, 2024
@leodemoura leodemoura removed this pull request from the merge queue due to a manual request Feb 23, 2024
@leodemoura leodemoura merged commit 338aa5a into master Feb 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-mathlib4-bot