Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove mkAppN macro in omega #3428

Merged
merged 2 commits into from
Feb 21, 2024
Merged

chore: remove mkAppN macro in omega #3428

merged 2 commits into from
Feb 21, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Feb 21, 2024 •
edited
Loading

No description provided.

@kim-em kim-em enabled auto-merge February 21, 2024 04:57
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 21, 2024 05:04 Inactive
@kim-em kim-em added this pull request to the merge queue Feb 21, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 21, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 959ad988611db082ae4a97e9b8c4390fab53352e --onto 8b8e001794e6a8b481d37f24fa77bb07797682a1. (2024-02-21 05:13:37)

Merged via the queue into master with commit 6719af3 Feb 21, 2024
10 checks passed
@nomeata
Copy link
Collaborator

nomeata commented Feb 21, 2024

In light of the discussion in https://lean-fro.zulipchat.com/#narrow/stream/398861-general/topic/Idioms.20for.20matching.20.60Expr.60 even the mkApp6 macro probably causes code bloat? But it’s just too damn practical in this case…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-em @leanprover-community-mathlib4-bot @nomeata