Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken internal links in the docs #3216

Merged

Conversation

david-christiansen
Copy link
Contributor

I deleted internal links that seemed to have the character of "TODO". I think that the residual TODO is of little value, given that we plan a big revamp and revision soon anyway, but I could do it some other way as well.

@david-christiansen david-christiansen marked this pull request as draft January 24, 2024 16:44
@david-christiansen
Copy link
Contributor Author

I'll need to debug the Netlify setup for PRs tomorrow, or perhaps just switch to a local on-disk link checker script.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 24, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. (2024-01-24 17:04:01)

@david-christiansen david-christiansen marked this pull request as ready for review January 25, 2024 08:57
@david-christiansen
Copy link
Contributor Author

OK, I think this is ready to go. It'll fix the broken links on the generated site and help prevent future issues.

@david-christiansen david-christiansen added this pull request to the merge queue Jan 25, 2024
Merged via the queue into leanprover:master with commit 1f4359c Jan 25, 2024
9 checks passed
@Kha Kha mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants