Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show inductive constructor argument names #249

Merged
merged 2 commits into from
Dec 17, 2024
Merged

feat: show inductive constructor argument names #249

merged 2 commits into from
Dec 17, 2024

Conversation

cppio
Copy link
Contributor

@cppio cppio commented Dec 17, 2024

Before:
old-docs
After:
new-docs

hargoniX
hargoniX reviewed Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@hargoniX hargoniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great apart from the one organisational remark.

DocGen4/Output/Inductive.lean Outdated
Render an `Arg` as HTML, adding opacity effects etc. depending on what
type of binder it has.
-/
def argToHtml (arg : Process.Arg) : HtmlM Html := do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this function into DocGen4.Output.Arg?

@hargoniX hargoniX merged commit e473211 into leanprover:main Dec 17, 2024
1 check passed
@cppio cppio deleted the ctor-args branch December 17, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hargoniX hargoniX hargoniX left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cppio @hargoniX