Slicing #19
Merged
Slicing #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmcl
force-pushed
the
sm/04-broadcast
branch
from
f82c5cb to
364614b
Compare
govereau
approved these changes
Jan 3, 2025
TensorLib/Slice.lean
Outdated
| > Defaults for i:j:k | ||
| > | ||
| > Assume n is the number of elements in the dimension being sliced. | ||
| > Then, if i is not given it defaults to 0 for step > 0 and n - 1 for step < 0 . |
There was a problem hiding this comment.
I think you are using step and k interchangeably
There was a problem hiding this comment.
Thanks, got my verbatim quote messed up. Fixed.
TensorLib/Slice.lean
Outdated
| def build (start stop step : Option Int) : Err Slice := | ||
| match H : step with | ||
| | .none => | ||
| let stepNz : step ≠ some 0 := by aesop |
There was a problem hiding this comment.
by aesop seems pretty heavy, is this just trivial?
There was a problem hiding this comment.
Well, close. Removed aesop here. Maybe we should come up with some conventions around automation should be.
TensorLib/Slice.lean
Outdated
|
|
||
| def all : Slice := | ||
| let stepNz : Option.none ≠ .some (0:Int) := by trivial | ||
| Slice.mk .none .none .none stepNz |
TensorLib/Slice.lean
Outdated
| iter := iter' | ||
| match <- f n res with | ||
| | .yield k | ||
| | .done k => res := k |
There was a problem hiding this comment.
Same comment as other review. Does this properly support break and return in the for loops?
There was a problem hiding this comment.
Fixed in the same way, added tests.
seanmcl
force-pushed
the
sm/04-broadcast
branch
from
364614b to
239e471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Python's slice operator, commonly used in NumPy indexing.