This repository has been archived by the owner on Aug 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Port the install.sh to lakefile.lean also.
- Loading branch information
1 parent
cbf73c9
commit 03460c5
Showing
4 changed files
with
53 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03460c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing into
.elan
is a horrible hack and doesn't make sense for LeanInk for the same reasons as #21 (comment). We should remove it.03460c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I agree, I changed it to install to
$HOME/.leanink/bin
, andC:\Users\clovett\AppData\Local\Programs\LeanInk\bin
on windows with output on how to modify your PATH, so user chooses how they want to do that part. For example, on Windows, I don't normally use system environment variables, I have other environment setup script (like conda) that I modify for stuff like this.03460c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said in the linked comment, it really doesn't make sense to install LeanInk outside of a specific target package, that's why I said we should remove the whole installation process.
03460c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has to be in your PATH somewhere in order for the manual book build instructions to work (so alectryon can find it).
03460c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, so let's put the local
build/bin
in the PATH (edit: not as a part of LeanInk setup, but wherever we use LeanInk)? See also the linked discussion.03460c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok you are right, I removed the install script, users can easily modify their own path to point to ~/LeanInk/build/bin.