chore: Make ArmState fields private to ensure that every field access is written in terms of r/w and read/write_mem_bytes #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bollu
force-pushed
the
private-fields-arm-state
branch
from
1d4a9cc to
9e8e198
Compare
shigoel
reviewed
Aug 1, 2024
shigoel
reviewed
Aug 1, 2024
shigoel
reviewed
Aug 2, 2024
pennyannn
reviewed
Aug 2, 2024
bollu
commented
Aug 2, 2024
Co-authored-by: Shilpi Goel <[email protected]>
|
@shigoel All comments addressed! |
shigoel
approved these changes
Aug 2, 2024
shigoel
pushed a commit
that referenced
this pull request
Aug 6, 2024
### Description: This fixes a conformance testing error introduced in #51, by reading the full 128 bits of an SFP register instead of only the lower 64 ### Testing: Conformance testing passed ### License: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up our definitions, and forces us to correctly the
read_*andwrite_*methods. This is important to allow us to reduce all (non)interference reasoning into ther/wfunctions.