-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shift related instructions #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pennyannn
force-pushed
the
yppe/shift
branch
10 times, most recently
from
March 9, 2024 00:13
b509aa9
to
0bb8a93
Compare
pennyannn
force-pushed
the
yppe/shift
branch
2 times, most recently
from
March 12, 2024 18:50
8065735
to
26f46f9
Compare
shigoel
reviewed
Mar 12, 2024
shigoel
reviewed
Mar 12, 2024
shigoel
reviewed
Mar 12, 2024
1. Add Advanced SIMD scalar shift by immediate (SHL, SSHR and USHR, SSRA and USRA, SRSHR and URSHR, SRSRA and URSRA) 2. Add Advanced SIMD (vector) shift by immediate (SHL, SSHR and USHR, SSRA and USRA, SRSHR and URSHR, SRSRA and URSRA) 3. Add Data processing two source class for shifts (LSLV)
nebeid
reviewed
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will continue reviewing. Thanks, Yan.
nebeid
reviewed
Mar 18, 2024
nebeid
approved these changes
Mar 18, 2024
shigoel
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @nebeid and @pennyannn!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Testing:
The
make all
succeeds and conformance testing runs successfully on Graviton2 and Graviton3.License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.