Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shift related instructions #25

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

pennyannn
Copy link
Collaborator

Description:

  1. Added advanced SIMD scalar shift by immediate instructions: SHL, SSHR and USHR, SSRA and USRA, SRSHR and URSHR, SRSRA and URSRA)
  2. Added advanced SIMD (vector) shift by immediate instructions: SHL, SSHR and USHR, SSRA and USRA, SRSHR and URSHR, SRSRA and URSRA)
  3. Added data processing two source class for variable shifts (LSLV, LSRV, ARSV, RORV 32-, 64-bit)

Testing:

The make all succeeds and conformance testing runs successfully on Graviton2 and Graviton3.

License:

By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

@pennyannn pennyannn force-pushed the yppe/shift branch 10 times, most recently from b509aa9 to 0bb8a93 Compare March 9, 2024 00:13
@pennyannn pennyannn force-pushed the yppe/shift branch 2 times, most recently from 8065735 to 26f46f9 Compare March 12, 2024 18:50
@pennyannn pennyannn marked this pull request as ready for review March 12, 2024 18:52
@pennyannn pennyannn requested review from shigoel and nebeid March 12, 2024 18:52
Arm/BitVec.lean Outdated Show resolved Hide resolved
Arm/Insts/Common.lean Outdated Show resolved Hide resolved
1. Add Advanced SIMD scalar shift by immediate (SHL, SSHR and USHR, SSRA and USRA,
SRSHR and URSHR, SRSRA and URSRA)

2. Add Advanced SIMD (vector) shift by immediate (SHL, SSHR and USHR, SSRA and
USRA, SRSHR and URSHR, SRSRA and URSRA)

3. Add Data processing two source class for shifts (LSLV)
Copy link
Collaborator

@nebeid nebeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will continue reviewing. Thanks, Yan.

Arm/Insts/DPSFP/Advanced_simd_shift_by_immediate.lean Outdated Show resolved Hide resolved
Arm/Decode.lean Show resolved Hide resolved
Arm/Insts/Common.lean Outdated Show resolved Hide resolved
Arm/Insts/DPSFP/Advanced_simd_shift_by_immediate.lean Outdated Show resolved Hide resolved
Copy link
Collaborator

@shigoel shigoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @nebeid and @pennyannn!

@shigoel shigoel merged commit 28dc04b into leanprover:main Mar 18, 2024
1 check passed
@pennyannn pennyannn deleted the yppe/shift branch March 19, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants