Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Advanced SIMD permute class for TRN1 and TRN2 #22

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

pennyannn
Copy link
Collaborator

@pennyannn pennyannn commented Feb 29, 2024

Description:

This PR adds support for [TRN1](https://developer.arm.com/documentation/ddi0602/2023-12/SIMD-FP-Instructions/TRN1--Transpose-vectors--primary--?lang=en) and TRN2 from class Advanced SIMD permute.

In addition, it refactors code involving Elem (non-assignment form) and Elem (assignment form). This reduces duplicated code and some unnecessary lemmas.

Testing:

The make all succeeds and conformance testing runs successfully on Graviton2 and Graviton3.

License:

By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

@pennyannn pennyannn marked this pull request as ready for review March 1, 2024 22:34
@pennyannn pennyannn requested a review from shigoel March 1, 2024 22:41
Arm/Insts/Common.lean Outdated Show resolved Hide resolved
@shigoel shigoel merged commit a506373 into leanprover:main Mar 5, 2024
1 check passed
@pennyannn pennyannn deleted the yppe/trn12 branch March 5, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants