Split sym1 into smaller tactics #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The work is ongoing. A macro-style tactic is chosen instead of the monad style so that developers can easily extend the tactics. However, this will change for a small set of tactics if they need more fine-grained manipulations.
aqjune-aws
commented
Feb 20, 2024
shigoel
reviewed
Feb 20, 2024
shigoel
reviewed
Feb 20, 2024
shigoel
reviewed
Feb 20, 2024
shigoel
reviewed
Feb 20, 2024
|
This looks fabulous, @aqjune-aws! Thank you so much. I have one more request: could you please add a couple of lines of comments describing what your macros are intended to achieve, and what their (known) limitations are? |
aqjune-aws
changed the title
|
Comments addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A macro-style tactic is chosen instead of the monad style so that developers can easily extend the tactics. However, this will change for a small set of tactics if they need more fine-grained manipulations.
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.