Avoid x18 entirely on Arm-based Apple machines
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`x18` is not used either as a source or destination register. Moreover, it is not expected to be preserved after a cosim test.
bollu
reviewed
Aug 21, 2024
bollu
reviewed
Aug 21, 2024
bollu
reviewed
Aug 21, 2024
Co-authored-by: Siddharth <[email protected]>
Co-authored-by: Siddharth <[email protected]>
shigoel
added a commit
that referenced
this pull request
Aug 21, 2024
### Description: Use `GPRIndex.rand` for a few instructions that I overlooked in #103 ### Testing: `make all` succeeds on my M3. ### License: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
x18is not used either as a source or destination register. Moreover, it is not expected to be preserved after a cosim test.This is expected to clear up the bogus mismatches we see on Arm-based Apple machines.
Another relevant PR: #98
Testing:
make allsucceeds on my M3.License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.