Ensure shadowed variables are inaccessible in quotations #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check which variables are shadowed in the meta-context, and make sure they are inaccessible in the quotation context (by making their
userName
hygienic).This PR is motivated by the following example (the described behaviour is as it is for master):
After the PR, the context inside the quotation still only has the first version of
n
, but it's made inaccessible$n✝: Nat := 1 ⊢ Nat
So that the
q($n)
line will throw anunknown identifier '«$n»'
error (which ideally would be anthe type of '«$n»' doesn't implement ToExpr
error, but that is an orthogonal issue).