-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GroupTheory/SpecificGroups): define an isomorphism between a non-cyclic group of order 4 and the dihedral group of order 4 #8360
Conversation
I wasn't sure where to place this definition. I imagine further classification of finite groups of small order would probably justify a dedicated "Mathlib/GroupTheory/SpecificGroups/SmallOrder.lean". |
A note on the final |
I have thoughts about this, please don't merge yet. |
I've just opened #8565, which I think may be the way we actually want to go about this (it implements @jcommelin suggestion from #7937 in this comment). With #8565, the result in this PR can be obtained as follows: import Mathlib.GroupTheory.SpecificGroups.KleinFour
variable {G : Type} [Group G] [Fintype G]
/-- A non-cyclic group of order 4 is isomorphic to the dihedral group of order 4. -/
noncomputable def mulEquivOfCardEqFourAndNotIsCyclic (h1 : Fintype.card G = 4) (h2 : ¬IsCyclic G) :
DihedralGroup 2 ≃* G :=
IsKleinFour.mulEquiv' ((Fintype.equivOfCardEq h1.symm : DihedralGroup 2 ≃ G).setValue 1 1)
(by simp) <| (IsKleinFour.not_isCyclic_iff h1).mp h2 |
Thanks @j-loreaux . |
I'm closing this PR in favour of #8565. |
This was suggested in a comment on #7937.