[Merged by Bors] - chore: remove reducible from Function.Surjective #5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is just an oversight, we've already removed Zulip discussion from today: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/simp.20lemmas.20with.20side.20conditions/near/366345908 bors d+ |
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
The @[reducible] attribute on `Function.Surjective` is apparently not needed, and currently prevents `@[simp]` lemmas with `Function.Surjective` side conditions from firing, see [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/simp.20lemmas.20with.20side.20conditions). Co-authored-by: Scott Morrison <[email protected]>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
alexkeizer
pushed a commit
that referenced
this pull request
Jun 22, 2023
The @[reducible] attribute on `Function.Surjective` is apparently not needed, and currently prevents `@[simp]` lemmas with `Function.Surjective` side conditions from firing, see [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/simp.20lemmas.20with.20side.20conditions). Co-authored-by: Scott Morrison <[email protected]>
kim-em
added a commit
that referenced
this pull request
Jun 25, 2023
The @[reducible] attribute on `Function.Surjective` is apparently not needed, and currently prevents `@[simp]` lemmas with `Function.Surjective` side conditions from firing, see [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/simp.20lemmas.20with.20side.20conditions). Co-authored-by: Scott Morrison <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
This was done once in #5063, then accidentally reverted in #5859. Co-authored-by: Scott Morrison <[email protected]>
kim-em
added a commit
that referenced
this pull request
Aug 3, 2023
This was done once in #5063, then accidentally reverted in #5859. Co-authored-by: Scott Morrison <[email protected]>
kim-em
added a commit
that referenced
this pull request
Aug 3, 2023
This was done once in #5063, then accidentally reverted in #5859. Co-authored-by: Scott Morrison <[email protected]>
kim-em
added a commit
that referenced
this pull request
Aug 14, 2023
This was done once in #5063, then accidentally reverted in #5859. Co-authored-by: Scott Morrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @[reducible] attribute on
Function.Surjectiveis apparently not needed, and currently prevents@[simp]lemmas withFunction.Surjectiveside conditions from firing, see zulip discussion.