Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CategoryTheory/Enriched/Limits): add HasConicalProducts #20963

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Jan 22, 2025

@joneugster joneugster added blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) infinity-cosmos This PR is associated with Infinity Cosmos project labels Jan 22, 2025
@github-actions github-actions bot added the t-category-theory Category theory label Jan 22, 2025
Copy link

PR summary f10631f68c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Enriched.Limits.IsConicalLimit (new file) 602
Mathlib.CategoryTheory.Enriched.Limits.HasConicalLimits (new file) 603
Mathlib.CategoryTheory.Enriched.Limits.HasConicalProducts (new file) 604

Declarations diff

+ ConicalLimitCone
+ HasConicalLimit
+ HasConicalLimits
+ HasConicalLimitsOfShape
+ HasConicalLimitsOfSize
+ HasConicalProduct
+ HasConicalProducts
+ IsConicalLimit
+ conicalLimit
+ conicalLimitCone
+ eCoyoneda
+ getConicalLimitCone
+ hasConicalLimitEquivalenceComp
+ hasConicalLimitOfEquivalenceComp
+ hasConicalLimitsOfSize_of_univLE
+ hasLimit
+ hasLimitsOfSize
+ hasProducts
+ instance (priority := 100) : HasConicalLimit V F
+ instance (priority := 100) [HasConicalLimitsOfSize.{v₁, u₁} V C] : HasConicalLimitsOfShape J V C
+ instance (priority := 100) hasSmallestConicalLimitsOfHasConicalLimits :
+ instance : HasConicalLimitsOfShape J V C := HasConicalLimitsOfSize.hasConicalLimitsOfShape J
+ instance : HasLimitsOfShape J C
+ isConicalLimit
+ isIso_limitComparison
+ lift
+ lift_π
+ limitComparison
+ limitComparisonIso
+ limitComparison_eq_conePointUniqueUpToIso
+ mk
+ nonempty_isConicalLimit_iff
+ ofIsIsoLimitComparison
+ of_equiv
+ shrink
+ w
+ π
++ ofIso

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment on lines +90 to +92
((h.isConicalLimit X).conePointUniqueUpToIso (limit.isLimit _)).hom := by
apply limit.hom_ext
simp [limitComparison]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
((h.isConicalLimit X).conePointUniqueUpToIso (limit.isLimit _)).hom := by
apply limit.hom_ext
simp [limitComparison]
((h.isConicalLimit X).conePointUniqueUpToIso (limit.isLimit _)).hom := rfl

also seems to work

@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) infinity-cosmos This PR is associated with Infinity Cosmos project t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants