Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: silence the #-command linter on noisy commands #20525

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jan 6, 2025

Reported on Zulip, the fix comes from this update.


Open in Gitpod

Copy link

github-actions bot commented Jan 6, 2025

PR summary b11bd6bc52

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.01)
Current number Change Type
198 -1 adaptation notes

Current commit b11bd6bc52
Reference commit 89f60e1045

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-linter Linter label Jan 6, 2025
@adomani adomani force-pushed the adomani/silence_hash_command_linter_when_messages_are_present branch from 987a121 to 27d8efe Compare January 6, 2025 19:27
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

Copy link

github-actions bot commented Jan 6, 2025

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@j-loreaux
Copy link
Collaborator

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 6, 2025

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@adomani
Copy link
Collaborator Author

adomani commented Jan 6, 2025

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 6, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: silence the #-command linter on noisy commands [Merged by Bors] - fix: silence the #-command linter on noisy commands Jan 6, 2025
@mathlib-bors mathlib-bors bot closed this Jan 6, 2025
@mathlib-bors mathlib-bors bot deleted the adomani/silence_hash_command_linter_when_messages_are_present branch January 6, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants