Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generalize IsLUB.mem_of_not_isSuccPrelimit to LinearOrder #20502

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jan 6, 2025

We also swap the arguments for two reasons:

  1. ¬ IsSuccPrelimit a is not a very common hypothesis, but IsSuccPrelimit a is a common thing (within the relevant files) to want to prove.
  2. The new proof works better with the arguments as they now are.

Open in Gitpod

@vihdzp vihdzp added awaiting-CI t-order Order theory labels Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

PR summary 1db7883082

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.IsGLB.isPredLimit_of_not_mem
+ _root_.IsGLB.isPredPrelimit_of_not_mem
+ _root_.IsLUB.isSuccLimit_of_not_mem
+ _root_.IsLUB.isSuccPrelimit_of_not_mem

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant