Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RingTheory/Smooth): calculate H¹(L) via formally smooth extensions #20471

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Jan 4, 2025


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

PR summary 8b7fa3b59f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Cotangent.map_toInfinitesimal_bijective
+ CotangentSpace.map_toInfinitesimal_bijective
+ H1Cotangent.equiv
+ H1Cotangent.equivOfFormallySmooth
+ H1Cotangent.map_toInfinitesimal_bijective
+ comap_cotangentIdeal
+ equivH1CotangentOfFormallySmooth
+ homInfinitesimal
+ infinitesimal
+ ker_infinitesimal
+ mk_mem_cotangentIdeal
+ range_cotangentToQuotientSquare
+ toInfinitesimal

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Mathlib/RingTheory/Ideal/Cotangent.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Kaehler/CotangentComplex.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Kaehler/CotangentComplex.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Smooth/Kaehler.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Smooth/Kaehler.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Smooth/Kaehler.lean Show resolved Hide resolved
Mathlib/RingTheory/Smooth/Kaehler.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Smooth/Kaehler.lean Outdated Show resolved Hide resolved
@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 6, 2025
@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes label Jan 6, 2025
Copy link
Collaborator

@chrisflav chrisflav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

Copy link

github-actions bot commented Jan 6, 2025

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 7, 2025
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 7, 2025

👎 Rejected by label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants