Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generalize results about LinearIndependent to Semiring #18503

Closed
wants to merge 6 commits into from

Conversation

eric-wieser
Copy link
Member


Open in Gitpod

Copy link

github-actions bot commented Nov 1, 2024

PR summary 7a8bb62fef

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Fintype.linearIndependent_iff_injective
+ LinearIndependent.map_of_injective_injective'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Nov 1, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 1, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 13, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 15, 2024
@alreadydone
Copy link
Contributor

alreadydone commented Jan 5, 2025

Oh, I wasn't aware of this PR until I searched GitHub in an attempt to find #18426 moments ago. I just opened #20480 to generalize all generalizable results to semirings (except I didn't examine the DivisionRing section carefully).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants