Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - docs: fix references.bib #14689

Closed
wants to merge 1 commit into from
Closed

Conversation

acmepjz
Copy link
Collaborator

@acmepjz acmepjz commented Jul 12, 2024

This PR removes \url and \_ commands in references.bib. The existence of them breaks leanprover/doc-gen4#209.

  • The first is howpublished = {\url{...}}. I think it's better to use the standard url field. Meanwhile howpublished field is preserved since some bibtex parser complains about missing that field.
  • There are some \_ in url and doi fields. I think it's better to replace them with _; there are already some _ in url and doi fields of other bibitems.
  • There is $K\_X$, but which, after checking the original article, should be $K_X$.

Open in Gitpod

@acmepjz acmepjz added documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Jul 12, 2024
Copy link

PR summary c1c39b9af3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@bryangingechen
Copy link
Contributor

Thanks!
bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 13, 2024
This PR removes `\url` and `\_` commands in `references.bib`. The existence of them breaks leanprover/doc-gen4#209.

- The first is `howpublished = {\url{...}}`. I think it's better to use the standard `url` field. Meanwhile `howpublished` field is preserved since some bibtex parser complains about missing that field.
- There are some `\_` in `url` and `doi` fields. I think it's better to replace them with `_`; there are already some `_` in `url` and `doi` fields of other bibitems.
- There is `$K\_X$`, but which, after checking the original article, should be `$K_X$`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title docs: fix references.bib [Merged by Bors] - docs: fix references.bib Jul 13, 2024
@mathlib-bors mathlib-bors bot closed this Jul 13, 2024
@mathlib-bors mathlib-bors bot deleted the acmepjz_bib_fix_2 branch July 13, 2024 03:54
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants