Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - doc: fix some author fields in references #14391

Closed
wants to merge 2 commits into from

Conversation

acmepjz
Copy link
Collaborator

@acmepjz acmepjz commented Jul 3, 2024


Open in Gitpod

@acmepjz acmepjz added documentation Improvements or additions to documentation awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

PR summary c381ef07ce

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@acmepjz
Copy link
Collaborator Author

acmepjz commented Jul 3, 2024

I think that \'{\i} is also wrong (it does not render correctly in my WIP pure Lean bibtex diacritic parser leanprover/doc-gen4#200), it should be \'i. Any opinions?

@acmepjz acmepjz changed the title doc: fix an author field in references doc: fix some author fields in references Jul 3, 2024
@acmepjz acmepjz added the awaiting-review-DONT-USE Read the "Changes to the #queue" announcement on Zulip label Jul 9, 2024
@faenuccio faenuccio removed the awaiting-review-DONT-USE Read the "Changes to the #queue" announcement on Zulip label Jul 9, 2024
@faenuccio
Copy link
Collaborator

I have removed the awaiting-review label according to the decision explained here
https://leanprover.zulipchat.com/#narrow/stream/113486-announce/topic/Changes.20to.20the.20.23queue/near/450176907

@acmepjz
Copy link
Collaborator Author

acmepjz commented Jul 9, 2024

I have removed the awaiting-review label according to the decision explained here https://leanprover.zulipchat.com/#narrow/stream/113486-announce/topic/Changes.20to.20the.20.23queue/near/450176907

I see. Sorry for the inconvenience.

@eric-wieser
Copy link
Member

I think that \'{\i} is also wrong (it does not render correctly in my WIP pure Lean bibtex diacritic parser leanprover/doc-gen4#200), it should be \'i. Any opinions?

https://tex.stackexchange.com/q/409927/41112 suggests that the original is valid, but unnecessary in modern LaTeX.

bors merge

Thanks!

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc: fix some author fields in references [Merged by Bors] - doc: fix some author fields in references Jul 9, 2024
@mathlib-bors mathlib-bors bot closed this Jul 9, 2024
@mathlib-bors mathlib-bors bot deleted the acmepjz_bib_1 branch July 9, 2024 23:50
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants