-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: redefine Nat.div2
Nat.bodd
#13649
Open
FR-vdash-bot
wants to merge
51
commits into
master
Choose a base branch
from
FR_binrec
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+73
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FR-vdash-bot
changed the title
chore: redefine Nat.binaryRec Nat.div2 Nat.bodd
chore: redefine Jun 9, 2024
Nat.binaryRec
Nat.div2
Nat.bodd
PR summary 8927b20a9bImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
1 task
Please describe how and why did you change the definition(s) in the commit message. |
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Jun 27, 2024
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Jul 13, 2024
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Jul 15, 2024
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Jul 15, 2024
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Jul 16, 2024
leanprover-community-bot-assistant
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Aug 30, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 20, 2024
This is #13649 with fewer definition changes.
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
label
Oct 20, 2024
This PR/issue depends on: |
@FR-vdash-bot, please solve the merge conflicts. |
leanprover-community-bot-assistant
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Oct 22, 2024
leanprover-community-bot-assistant
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Oct 22, 2024
leanprover-community-bot-assistant
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Oct 23, 2024
leanprover-community-bot-assistant
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Nov 22, 2024
leanprover-community-bot-assistant
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Dec 1, 2024
FR-vdash-bot
changed the title
chore: redefine
chore: redefine Dec 1, 2024
Nat.bit
Nat.div2
Nat.bodd
Nat.div2
Nat.bodd
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
label
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new definitions are faster than the old ones.
Nat.binaryRec
will be moved to batteries (leanprover-community/batteries#799) or core (leanprover/lean4#3756), so relevant contents are moved to a new file temporarily.Nat
into a new file #15567Nat.bit
andcsimp
lemma forNat.bit
#19666