-
Notifications
You must be signed in to change notification settings - Fork 298
[Merged by Bors] - split(topology/algebra/infinite_sum): Split into four files #18414
Conversation
|
(I didn't request a split, only a reorder; but I'm not opposed either) |
Do you think this changes the way these files should be split? Note that it's not enough to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This split generally looks reasonable to me. My main comments would be:
infinite_sum
might be preferable tobig_operators
as a name; it doesn't matter to me, but might to other reviewerstopology.algebra.module.infinite_sum
feels out of place now that the other file is not calledinfinite_sum
.- I'm not convinced about the placement of the
smul
lemmas, but that's minor. - The docstrings of (some) of the new files could maybe do with a "main results" section.
|
big_operators
big_operators
big_operators
big_operators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
Thanks!
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
Over the past five years, `topology.algebra.infinite_sum` has grown pretty big. This PR splits off a third of it to three new files. Precisely, split `topology.algebra.infinite_sum` into: * `topology.algebra.infinite_sum.basic`: Definitions and theory in monoids. All this will be multiplicativised in #18405. * `topology.algebra.infinite_sum.ring`: Interaction of infinite sums and (scalar) multiplication. This mostly cannot be multiplicativised. * `topology.algebra.infinite_sum.order`: Interaction of infinite sums and order. Most of this will be multiplicativised in #18405. Incidentally, this brings down some files' imports by quite a lot. Also move the `star` and `mul_opposite` material to the end of the file to facilitate multiplicativisation in #18405. Johannes wrote some of all these files, except `topology.algebra.infinite_sum.real` whose first lemma I could trace back as coming from #753, with the others coming from #1739.
Build failed: |
bors merge |
Over the past five years, `topology.algebra.infinite_sum` has grown pretty big. This PR splits off a third of it to three new files. Precisely, split `topology.algebra.infinite_sum` into: * `topology.algebra.infinite_sum.basic`: Definitions and theory in monoids. All this will be multiplicativised in #18405. * `topology.algebra.infinite_sum.ring`: Interaction of infinite sums and (scalar) multiplication. This mostly cannot be multiplicativised. * `topology.algebra.infinite_sum.order`: Interaction of infinite sums and order. Most of this will be multiplicativised in #18405. Incidentally, this brings down some files' imports by quite a lot. Also move the `star` and `mul_opposite` material to the end of the file to facilitate multiplicativisation in #18405. Johannes wrote some of all these files, except `topology.algebra.infinite_sum.real` whose first lemma I could trace back as coming from #753, with the others coming from #1739.
Pull request successfully merged into master. Build succeeded: |
Over the past five years,
topology.algebra.infinite_sum
has grown pretty big. This PR splits off a third of it to three new files. Precisely, splittopology.algebra.infinite_sum
into:topology.algebra.infinite_sum.basic
: Definitions and theory in monoids. All this will be multiplicativised in feat(topology/algebra/infinite_sum): Multiplicativise #18405.topology.algebra.infinite_sum.ring
: Interaction of infinite sums and (scalar) multiplication. This mostly cannot be multiplicativised.topology.algebra.infinite_sum.order
: Interaction of infinite sums and order. Most of this will be multiplicativised in feat(topology/algebra/infinite_sum): Multiplicativise #18405.Incidentally, this brings down some files' imports by quite a lot.
Also move the
star
andmul_opposite
material to the end of the file to facilitate multiplicativisation in #18405.Johannes wrote some of all these files, except
topology.algebra.infinite_sum.real
whose first lemma I could trace back as coming from #753, with the others coming from #1739.Partially requested by @eric-wieser