This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(topology/order/basic): Move #17860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
1 task
|
LGTM, let's just ping some analysis "old-timers" in case they have strong feelings. (This weird-in-my-opinion folder choice was before my time.) |
eric-wieser
reviewed
Dec 8, 2022
| import algebra.order.archimedean | ||
|
|
||
| /-! | ||
| # Rational numbers are dense in a linear ordered archimedean field | ||
|
|
||
| In this file we prove that coercion from `ℚ` to a linear ordered archimedean field has dense range. | ||
| This lemma is in a separate file because `topology.algebra.order.basic` does not import |
There was a problem hiding this comment.
Just as a heads up for #17859, this comment will want to say topology.algebra.order.basic again after the split (no action needed in this PR).
eric-wieser
approved these changes
Dec 8, 2022
|
bors merge |
github-actions
bot
added
ready-to-merge
|
bors p=10 |
bors bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
Rename `topology.algebra.order.basic` to `topology.order.basic` because it's almost entirely not about algebra.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
topology.algebra.order.basictotopology.order.basicbecause it's almost entirely not about algebra.