Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

chore(topology/order/*): Move #17859

Closed
wants to merge 2 commits into from
Closed

chore(topology/order/*): Move #17859

wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Dec 8, 2022

Move files from topology.algebra.order. to topology.order. when they do not contain any algebra. Move the non-algebra bit of topology.algebra.order.basic to topology.order.basic.


Open in Gitpod

@YaelDillies YaelDillies requested a review from a team as a code owner December 8, 2022 14:54
@YaelDillies YaelDillies added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR t-order Order hierarchy t-topology Topological spaces, uniform spaces, metric spaces, filters labels Dec 8, 2022
@hrmacbeth
Copy link
Member

I fully approve moving topology.algebra.order.* to topology.order.*, but I think it should be done more thoroughly -- I don't think there's a reason to leave anything in the old folder topology.algebra.order.*, everything there is more closely related to the files in the new topology.order.* than the new topology.algebra.*

import topology.algebra.group.basic
import topology.algebra.order.left_right
import topology.order.basic

/-!
# Theory of topology on ordered spaces
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure that this docstring doesn't duplicate topology/order/basic.lean? It looks like right now they're the same as each other.

It looks to me like this docstring is basically all about the non-algebraic file.

@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 8, 2022
@YaelDillies
Copy link
Collaborator Author

YaelDillies commented Dec 8, 2022

I fully approve moving topology.algebra.order.* to topology.order.*, but I think it should be done more thoroughly -- I don't think there's a reason to leave anything in the old folder topology.algebra.order.*, everything there is more closely related to the files in the new topology.order.* than the new topology.algebra.*

In fact I moved all files under topology.algebra.order. that didn't mention algebra to topology.order., but files such as topology.algebra.order.field definitely deserve to stay under topology.algebra..

Note that topology.order. also contains material about categorical logic, where topological spaces and orders interact in ways that are quite different to what you would expect from the reals, say.

@hrmacbeth
Copy link
Member

hrmacbeth commented Dec 8, 2022

files such as topology.algebra.order.field definitely deserve to stay under topology.algebra..

I disagree somewhat. My criterion would be: if it's about the order topology of a linear_ordered_field, it should live in topology.order.*. If it's about a topological_division_ring, it should live in topology.algebra.*. If it's one of the small number of declarations relating the two concepts, I don't care.

Note that topology.order. also contains material about categorical logic, where topological spaces and orders interact in ways that are quite different to what you would expect from the reals, say.

Do you think it's ambiguous to put this material in the same folder as all the order_topology stuff? If so, we can put them in separate folders, but since the order_topology stuff is much more central in mathlib, maybe it should get the good name topology.order.*? I don't have a strong opinion here.

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Dec 8, 2022
@eric-wieser eric-wieser added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 9, 2022
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 9, 2022
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@eric-wieser eric-wieser added the not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 label Jul 15, 2023
@urkud
Copy link
Member

urkud commented Sep 19, 2023

It's not-too-late but it has lots of merge conflicts. What's your plan: merge master or drop & redo in Mathlib 4?

@eric-wieser eric-wieser removed the not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 label Mar 23, 2024
@eric-wieser
Copy link
Member

Removing the not-too-late label; while we may still want this in mathlib4, it doesn't seem likely that mathport will help.

@eric-wieser eric-wieser added the too-late This PR was ready too late for inclusion in mathlib3 label Mar 23, 2024
@YaelDillies YaelDillies removed awaiting-review The author would like community review of the PR too-late This PR was ready too late for inclusion in mathlib3 labels Mar 23, 2024
@YaelDillies YaelDillies removed the request for review from a team March 23, 2024 15:15
@YaelDillies
Copy link
Collaborator Author

Redone in leanprover-community/mathlib4#11610.

@YaelDillies YaelDillies deleted the move_topology_order branch March 23, 2024 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merge-conflict Please `git merge origin/master` then a bot will remove this label. t-order Order hierarchy t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants