Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change from webpack to vite #3

Merged
merged 14 commits into from
Oct 27, 2023
Merged

feat: change from webpack to vite #3

merged 14 commits into from
Oct 27, 2023

Conversation

joneugster
Copy link
Collaborator

No description provided.

@abentkamp
Copy link
Collaborator

Oh, I forgot about the Logo

@joneugster
Copy link
Collaborator Author

joneugster commented Oct 24, 2023 •
edited
Loading

  • Currently it's starting on http://localhost:5173. Can we change that back to 3000 or update the documentation?

joneugster
joneugster commented Oct 24, 2023
View reviewed changes
server/LeanProject/.gitignore Show resolved Hide resolved
package.json Show resolved Hide resolved
index.html Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought files from client/public are copied to the server. Why do we need this copy?

client/src/editor/leanclient.ts Show resolved Hide resolved
@joneugster
Copy link
Collaborator Author

@abentkamp do you understand this CI warning?

@abentkamp
Copy link
Collaborator

The module path is only meant to be used on the server side (nodejs). webpack replaces it automatically with path-browserify. I used this vite configuration to fix the issue:
https://dev.to/0xbf/vite-module-path-has-been-externalized-for-browser-compatibility-2bo6

@joneugster
Copy link
Collaborator Author

joneugster commented Oct 25, 2023 •
edited
Loading

Now I get an error about the logo again.

@joneugster joneugster merged commit 149f1c7 into main Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abentkamp abentkamp abentkamp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joneugster @abentkamp