chore: fixes for new simp default (decide := false) (lean4#2722)
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collares
changed the title
decide := false) (lean4#2722)
collares
force-pushed
the
lean-pr-testing-2722
branch
3 times, most recently
from
a2657ee to
60a1ddf
Compare
kim-em
added
the
depends on core changes
kim-em
reviewed
Oct 21, 2023
|
These changes seem pretty reasonable to me. |
3 tasks
collares
force-pushed
the
lean-pr-testing-2722
branch
from
60a1ddf to
ed5610b
Compare
leanprover-community-mathlib4-bot
added
the
merge-conflict
collares
force-pushed
the
lean-pr-testing-2722
branch
from
ed5610b to
6f724a0
Compare
leanprover-community-mathlib4-bot
removed
the
merge-conflict
collares
force-pushed
the
lean-pr-testing-2722
branch
from
a81cb02 to
e930b99
Compare
|
awaiting-review |
github-actions
bot
added
the
awaiting-review
collares
force-pushed
the
lean-pr-testing-2722
branch
2 times, most recently
from
986f0db to
66f20fc
Compare
|
@digama0, @joehendrix, could this please be reviewed and merged? Note that this will go into the After this is merged I will merge leanprover-community/mathlib4#7834 into Mathlib's |
collares
force-pushed
the
lean-pr-testing-2722
branch
from
66f20fc to
029d701
Compare
digama0
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to new default in Lean master.