-
Notifications
You must be signed in to change notification settings - Fork 81
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove Gemfile.lock, see https://yehudakatz.com/2010/12/16/clarifying…
- Loading branch information
1 parent
f2f9cab
commit 84228a0
Showing
3 changed files
with
1 addition
and
65 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
coverage/ | ||
.bundle/ | ||
dump.rdb | ||
Gemfile.lock |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84228a0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sirwolfgang That Yehuda Katz post is 12 years old, and is no longer considered best practice. It is still true that you do not want to ship the
Gemfile.lock
with the gem. End users don't want it. However, it is useful for developers of the gem to share a common set of libraries to work with.Best practice, according to RubyGems/Bundler, is now to commit the
Gemfile.lock
into version control for gem libraries.rubygems/rubygems#3372
84228a0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again @pboling for my dev env, it always nice to have it up, let's bring it back!