Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
sirwolfgang committed Feb 1, 2023
1 parent f2f9cab commit 84228a0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 65 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
coverage/
.bundle/
dump.rdb
Gemfile.lock
62 changes: 0 additions & 62 deletions Gemfile.lock

This file was deleted.

3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,3 @@ build:

publish:
docker-compose run --rm test gem push `ls -lt *gem | head -n 1 | awk '{ print $$9 }'`

updateLock:
docker-compose run --rm test bundle lock --update

2 comments on commit 84228a0

@pboling
Copy link

@pboling pboling commented on 84228a0 Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirwolfgang That Yehuda Katz post is 12 years old, and is no longer considered best practice. It is still true that you do not want to ship the Gemfile.lock with the gem. End users don't want it. However, it is useful for developers of the gem to share a common set of libraries to work with.

Best practice, according to RubyGems/Bundler, is now to commit the Gemfile.lock into version control for gem libraries.
rubygems/rubygems#3372

@leandromoreira
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirwolfgang That Yehuda Katz post is 12 years old, and is no longer considered best practice. It is still true that you do not want to ship the Gemfile.lock with the gem. End users don't want it. However, it is useful for developers of the gem to share a common set of libraries to work with.

Best practice, according to RubyGems/Bundler, is now to commit the Gemfile.lock into version control for gem libraries. rubygems/rubygems#3372

Thank you again @pboling for my dev env, it always nice to have it up, let's bring it back!

Please sign in to comment.