contrib/mmailto: Fix using longer arguments #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We put the args to $TERMINAL inside single quotes for terminals that want a single command, and we put arguments extracted from the adress between double quotes to protect from spaces
|
Regarding the original patch: since we set IFS, I don't think this is necessary? |
|
Ah, sorry about the unrelated stuff I added by mistake.
After further testing, if I understand correctly, it seems that xfce4-terminal must have arguments after `-e` inside quotes, and when adding quotes the newlines don't seem to work anymore. Going back to args within quotes make it work, but it might not be the prettiest solution, I'll admit.
…--
Matthieu Rakotojaona
|
|
Try gnome-terminal just uses |
|
I don't think upstream will change the way it works, so I'll just keep a personal diff locally. The idea of configuring the flag is worth a try for the future.
Closing this PR now.
…--
Matthieu Rakotojaona
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We put the args to $TERMINAL inside single quotes for terminals that want a single command, and we put arguments extracted from the adress between double quotes to protect from spaces.
This is necessary for
xfce4-terminalfor example, and doesn't breakxterm