-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chinese & Uighur fixes. #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add personal name handling in Chinese.
thisismattmiller
previously approved these changes
Oct 22, 2024
Move preloading.
thisismattmiller
previously approved these changes
Dec 3, 2024
scossu
dismissed
thisismattmiller’s stale review
December 5, 2024 03:55
The merge-base changed after approval.
thisismattmiller
previously approved these changes
Dec 5, 2024
scossu
dismissed
thisismattmiller’s stale review
December 5, 2024 17:31
The merge-base changed after approval.
thisismattmiller
approved these changes
Dec 5, 2024
thisismattmiller
previously approved these changes
Dec 5, 2024
scossu
dismissed
thisismattmiller’s stale review
December 8, 2024 18:06
The merge-base changed after approval.
thisismattmiller
previously approved these changes
Dec 9, 2024
scossu
dismissed
thisismattmiller’s stale review
December 9, 2024 21:50
The merge-base changed after approval.
thisismattmiller
approved these changes
Dec 9, 2024
I keep adding my review approval, and it keeps asking for it, not sure why. |
I've had this happen today on another project too. It might be a new bug in Github. I can just force-push the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.