-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frequent Directions Modules #329
base: main
Are you sure you want to change the base?
Conversation
… working other than segfault high core issue.
…re the sketches are useful until I implement something substantial
…eed to verify run with application.
…ve intermediate results h5 files.
Hi @john-winnicki, running your script on S3DF seemed to work:
And completed without errors.
If you are happy with this, please:
Once this is done, please click on "Ready to review" and we'll continue discussing from there. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @john-winnicki for this great contribution!
Please check my comments and let me know if you want to discuss them offline. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @john-winnicki - this looks great!
…in code review in this commit.
…wards parent class (reverting old functions to pipca versions).
…ctions are housed here for Frequent Directions and PIPCA module. ALso appropriately modified FD and PIPCA code. Fixed indexing issue, removed means, zeroed negative values and fixed overflowing issues. Other nice changes.
…e a time bottleneck
Disabling common mode correction in FredDir DataRetriever.
created FD sketch tasks and workflow.
…visualization step.
…d thumbnail generation outside of sketching. Other small updates.
…raw_sketch task able to run on more than one core.
…duler), the pythonpath needs to be given as well, otherwise python or mpirun defaults to the original environment.
…to re-enable ROI and the things in the settings (I think no threshold, but throw away zeros and apply unit variance and possibly normalization).
…ng script and run and single panel stuff.
…ot being scaled correctly using the new boxing mechanism.
Parallelized Fast Alpha Frequent Directions with Tree Merging and Data Projection.
The implementation is separated into three separate modules which are designed to be applied serially:
Example Python Script for running modules:
Example Slurm File