Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PRT - add lava consumer blocked providers metrics #1919

Conversation

ranlavanet
Copy link
Collaborator

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

oren-lava added 30 commits July 31, 2024 14:01
…B-add-lava_consumer_blocked_provider_metrics
…rovider_metrics

feat: added lava_consumer_provider_blocked metric
Copy link

github-actions bot commented Jan 20, 2025

Test Results

2 423 tests  ±0   2 422 ✅ ±0   20m 54s ⏱️ + 1m 27s
  122 suites ±0       0 💤 ±0 
    7 files   ±0       1 ❌ ±0 

For more details on these failures, see this check.

Results for commit bdafe1a. ± Comparison against base commit 8943739.

♻️ This comment has been updated with latest results.

Copy link
Collaborator Author

@ranlavanet ranlavanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a possible issue with locks when resetting the gauge

@ranlavanet ranlavanet self-assigned this Jan 20, 2025
@@ -102,6 +102,9 @@ func (csm *ConsumerSessionManager) UpdateAllProviders(epoch uint64, pairingList
csm.reportedProviders.Reset()
csm.pairingAddressesLength = uint64(pairingListLength)
csm.numberOfResets = 0

providerAddressToEndpoint := map[string]string{}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from csm.pairing?

@shleikes shleikes changed the base branch from main to PRT-fb-branch-with-offline-policy-v-4-2-5 January 21, 2025 09:44
@ranlavanet ranlavanet merged commit aad9f4d into PRT-fb-branch-with-offline-policy-v-4-2-5 Jan 21, 2025
28 of 30 checks passed
@ranlavanet ranlavanet deleted the PRT-add-lava-consumer-blocked-providers-metrics branch January 21, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants