Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install JRE if user_answer is nil. #319

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/s3_website
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def autoinstall_java_or_print_help_and_exit(logger)
if automatic_method
@logger.info_msg "Do you want me to install Java with the command `#{automatic_method.fetch(:install_command)}`? [Y/n]"
user_answer = $stdin.gets
if user_answer.chomp.downcase == 'y' or user_answer == "\n"
if user_answer.chomp.downcase == 'y' or user_answer == "\n" or user_answer.nil?
automatic_method_succeeded = system automatic_method.fetch(:install_command)
unless automatic_method_succeeded
@logger.fail_msg "Could not automatically install Java. Try setting it up manually:"
Expand Down
2 changes: 1 addition & 1 deletion s3_website.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Gem::Specification.new do |s|
s.add_dependency 'colored', '1.2'
s.add_dependency 'dotenv', '~> 1.0'

s.add_development_dependency 'rake', '10.1.1'
s.add_development_dependency 'rake', '12.3.3'
s.add_development_dependency 'octokit', '3.1.0'
s.add_development_dependency 'mime-types'

Expand Down