iOS: Resolves #11119: Add iOS Dark Icon

[itzTheMeow]

Resolves #11119.

Implements the dark icon for iOS 18, and converts the AppIcon asset to use the "Single Size" format rather than "All Sizes (Xcode 13)" format.
I tested the icon on the iPhone 16 simulator and it becomes dark and tinted properly.

[laurent22]

Thanks for the PR. I haven't reviewed yet but would you mind sharing screenshots of how it would be with this change?

[itzTheMeow]

[laurent22]

Thanks for the update. I see that you removed the icons of various sizes - those are no longer needed, even for older devices?

[itzTheMeow]

From my research, the only devices that would be affected are iOS 12 and under, which the Joplin app doesn't support.
Xcode 14 release notes: https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes#Asset-Catalogs
Documentation for app icons: https://developer.apple.com/documentation/xcode/configuring-your-app-icon#Specify-app-icon-variations

Seems like Xcode added the white space changes, i'll revert.

[laurent22]

Thanks a lot for implementing this @itzTheMeow!

[laurent22]

@itzTheMeow, unfortunately I had to revert this change for now as it's not being accepted by Apple's servers.

The errors I'm getting are these ones:

Asset validation failed

Missing Info.plist value. A value for the Info.plist key 'CFBundleIconName' is missing in the bundle 'net.cozic.joplin'. Apps built with iOS 11 or later SDK must supply app icons in an asset catalog and must also provide a value for this Info.plist key. For more information see http://help.apple.com/xcode/mac/current/#/dev10510b1f7. (ID: 6ee761d1-9848-4fb4-b586-1a14eaf8c59c)

Asset validation failed

Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '120x120' pixels, in .png format for iOS versions >= 10.0. To support older versions of iOS, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface (ID: f28130a8-d88a-439d-b631-9718e6535350)

Asset validation failed

Missing required icon file. The bundle does not contain an app icon for iPad of exactly '167x167' pixels, in .png format for iOS versions supporting iPad Pro. To support older operating systems, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface (ID: 487a277c-a069-4f59-96f6-f3f3d83400e0)

Asset validation failed

Missing required icon file. The bundle does not contain an app icon for iPad of exactly '152x152' pixels, in .png format for iOS versions >= 10.0. To support older operating systems, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface (ID: b534a218-a9d7-4330-bbe3-35f09a6a4fa7)

And it's been reverted in edbb613. Please let me know if you have any suggestions on how to fix this.

[itzTheMeow]

Just saw this, sorry. I'll take a look at it when i have time.

[itzTheMeow]

What is the build process used for submitting a new release? (xcode version, setup, etc)