Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix how we find num replicas for endpoints and collectors #340

Merged
merged 3 commits into from
Dec 22, 2023
Merged

fix how we find num replicas for endpoints and collectors #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdec71d
bump version for next release
boetro Dec 21, 2023
cf0be2d
fix how we find num replicas for endpoints and collectors
boetro Dec 21, 2023
03d3ed3
Merge remote-tracking branch 'upstream/main'
boetro Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion buildflow/core/app/runtime/actors/collector_pattern/receive_process_push_ack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,12 @@
avg_process_time_millis=0,
)
if self.collector_deployment is not None:
num_replicas = self.collector_deployment.num_replicas
num_replicas = (

Check warning on line 161 in buildflow/core/app/runtime/actors/collector_pattern/receive_process_push_ack.py

View check run for this annotation

Codecov / codecov/patch

buildflow/core/app/runtime/actors/collector_pattern/receive_process_push_ack.py#L161 

Added line #L161 was not covered by tests
serve.status()
.applications.get(self.processor_group.group_id, {})
.deployments.get(self.endpoint_deployment.name, {})
.replica_states.get("RUNNING", 0)
)
else:
num_replicas = 0

Expand Down
7 changes: 6 additions & 1 deletion buildflow/core/app/runtime/actors/endpoint_pattern/receive_process_respond.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,12 @@
avg_process_time_millis=0,
)
if self.endpoint_deployment is not None:
num_replicas = self.endpoint_deployment.num_replicas
num_replicas = (

Check warning on line 149 in buildflow/core/app/runtime/actors/endpoint_pattern/receive_process_respond.py

View check run for this annotation

Codecov / codecov/patch

buildflow/core/app/runtime/actors/endpoint_pattern/receive_process_respond.py#L149 

Added line #L149 was not covered by tests
serve.status()
.applications.get(self.processor_group.group_id, {})
.deployments.get(self.endpoint_deployment.name, {})
.replica_states.get("RUNNING", 0)
)
else:
num_replicas = 0

Expand Down
Loading