Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose ack id in pub/sub message #325

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

boetro
Copy link
Collaborator

@boetro boetro commented Dec 4, 2023

This will allow users to extend the ack deadline if needed

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 1476 lines in your changes are missing coverage. Please review.

Comparison is base (0b616bb) 78.72% compared to head (ccb3cf1) 74.53%.
Report is 86 commits behind head on main.

Files Patch % Lines
...ntime/actors/consumer_pattern/pull_process_push.py 23.29% 135 Missing ⚠️
buildflow/core/app/flow.py 72.41% 128 Missing ⚠️
buildflow/core/app/runtime/fastapi.py 18.01% 91 Missing ⚠️
buildflow/core/app/runtime/actors/runtime.py 18.09% 86 Missing ⚠️
...ake/background_tasks/table_load_background_task.py 32.00% 85 Missing ⚠️
buildflow/core/app/infra/actors/infra.py 12.08% 80 Missing ⚠️
...tors/collector_pattern/receive_process_push_ack.py 34.06% 60 Missing ⚠️
...p/runtime/actors/consumer_pattern/consumer_pool.py 26.58% 58 Missing ⚠️
...actors/endpoint_pattern/receive_process_respond.py 39.74% 47 Missing ⚠️
buildflow/core/processor/utils.py 23.52% 39 Missing ⚠️
... and 77 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   78.72%   74.53%   -4.19%     
==========================================
  Files         103      168      +65     
  Lines        3648     7537    +3889     
==========================================
+ Hits         2872     5618    +2746     
- Misses        776     1919    +1143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boetro boetro merged commit 2ed1b11 into launchflow:main Dec 4, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant