Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with websockets and query params, remove idle status #303

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

boetro
Copy link
Collaborator

@boetro boetro commented Oct 31, 2023

No description provided.

@boetro boetro requested a review from JoshTanke as a code owner October 31, 2023 21:00
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (d00bf38) 77.42% compared to head (b93a9b6) 77.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   77.42%   77.61%   +0.19%     
==========================================
  Files         162      162              
  Lines        7215     7179      -36     
==========================================
- Hits         5586     5572      -14     
+ Misses       1629     1607      -22     
Files Coverage Δ
buildflow/core/app/infra/_infra.py 100.00% <ø> (ø)
buildflow/core/app/infra/actors/infra.py 90.72% <100.00%> (+10.21%) ⬆️
buildflow/core/app/runtime/_runtime.py 100.00% <100.00%> (ø)
buildflow/core/processor/utils.py 23.52% <ø> (ø)
end_to_end_tests/endpoint_test.py 82.41% <75.00%> (ø)
...actors/endpoint_pattern/receive_process_respond.py 39.74% <0.00%> (-0.52%) ⬇️
buildflow/core/app/runtime/actors/process_pool.py 41.34% <0.00%> (+2.60%) ⬆️
buildflow/core/app/runtime/actors/runtime.py 33.61% <0.00%> (+1.83%) ⬆️
...tors/collector_pattern/receive_process_push_ack.py 34.06% <0.00%> (-0.77%) ⬇️
...ntime/actors/consumer_pattern/pull_process_push.py 22.67% <0.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boetro boetro merged commit 8e8ef36 into launchflow:main Oct 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant