Skip to content

Commit

Permalink
fix some language with buildflow cli docs (#329)
Browse files Browse the repository at this point in the history
  • Loading branch information
boetro authored Dec 7, 2023
1 parent 7f2b021 commit 5b5e14c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 14 deletions.
18 changes: 9 additions & 9 deletions buildflow/cli/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ def run_flow(
event_subscriber=event_subscriber,
)
else:
typer.echo(f"{app} is not a buildflow flow.")
typer.echo(f"{app} is not a buildflow.Flow object.")
raise typer.Exit(1)


@app.command(help="Run a buildflow flow.")
@app.command(help="Run a buildflow application.")
def run(
serve_host: str = typer.Option(
"127.0.0.1", help="The host to use for serving endpoints and collectors."
Expand Down Expand Up @@ -203,10 +203,10 @@ def zipdir(path: str, ziph: zipfile.ZipFile, excludes: List[str]):


_BASE_EXCLUDE = [".buildflow", "__pycache__", "build", ".git", ".gitignore"]
_BUILD_PATH_HELP = "Output director to store the build in, defaults to ./.buildflow/build/build.flow" # noqa
_BUILD_PATH_HELP = "Output directory to store the build in, defaults to ./.buildflow/build/build.flow" # noqa


@app.command(help="Build a buildflow flow.")
@app.command(help="Build a buildflow application.")
def build(
build_path: str = typer.Option("", help=_BUILD_PATH_HELP),
ignores: List[str] = typer.Option(
Expand Down Expand Up @@ -247,7 +247,7 @@ def build(
typer.Exit(1)


@app.command(help="Refresh all resources used by a buildflow flow")
@app.command(help="Refresh all resources used by a buildflow application")
def refresh():
buildflow_config = BuildFlowConfig.load()
sys.path.insert(0, "")
Expand All @@ -260,7 +260,7 @@ def refresh():
typer.Exit(1)


@app.command(help="Output all resources used by a buildflow flow")
@app.command(help="Output all resources used by a buildflow application")
def preview():
with Progress(
SpinnerColumn(),
Expand All @@ -280,7 +280,7 @@ def preview():
typer.Exit(1)


@app.command(help="Apply all resources used by a buildflow flow")
@app.command(help="Apply all resources used by a buildflow application")
def apply():
with Progress(
SpinnerColumn(),
Expand All @@ -301,7 +301,7 @@ def apply():
typer.Exit(1)


@app.command(help="Destroy all resources used by a buildflow flow ")
@app.command(help="Destroy all resources used by a buildflow application ")
def destroy():
with Progress(
SpinnerColumn(),
Expand Down Expand Up @@ -332,7 +332,7 @@ def print_json(self):
print(json.dumps(asdict(self)))


@app.command(help="Inspect the Pulumi Stack state of a buildflow flow")
@app.command(help="Inspect the Pulumi Stack state of a buildflow application")
def inspect(
as_json: bool = typer.Option(False, help="Whether to print the output as json"),
):
Expand Down
5 changes: 0 additions & 5 deletions buildflow/io/gcp/strategies/pubsub_strategies.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,7 @@ async def pull(self) -> PullResponse:

payloads = []
ack_ids = []
msg_ids = set()
for received_message in response.received_messages:
if received_message.message.message_id in msg_ids:
continue
else:
msg_ids.add(received_message.message.message_id)
if self.include_attributes:
att_dict = {}
attributes = received_message.message.attributes
Expand Down

0 comments on commit 5b5e14c

Please sign in to comment.