chore: create release-please-config.json #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldhenry
requested changes
Dec 9, 2024
| contents: write | ||
| pull-requests: write | ||
| outputs: | ||
| release-created: ${{ steps.release.outputs.release_created }} |
There was a problem hiding this comment.
Suggested change
| release-created: ${{ steps.release.outputs.release_created }} | |
| release-created: ${{ steps.release.outputs.releases_created }} |
ldhenry
reviewed
Dec 9, 2024
Comment on lines
+11
to
+13
| outputs: | ||
| release-created: ${{ steps.release.outputs.release_created }} | ||
| upload-tag-name: ${{ steps.release.outputs.tag_name }} |
There was a problem hiding this comment.
These outputs are only needed if we had a separate job that needed to reference them. Based on how you have it now, we could just get rid of them.
Alternatively, we could make the goreleaser stuff a separate job that only runs if a release is created. That might actually be a cleaner implementation because we wouldn't have to call if: ${{ steps.release.outputs.releases_created == 'true' }} in every step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to test this PR but the release please action is trying to pull this configuration file from main. So I guess I have to merge this into main first.