fix: properly terminate inbound SSE connections #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various contract tests that do something like:
It appears that the code that was supposed to terminate inbound HTTP connections (
breakConnection
) was incorrect/not doing anything.Reading the docs for
http.Request
:Note the emphasis. For incoming server requests, the context is canceled by the server, not by calling the
context.Cancel
function. Therefore, all the machinery related to storing context cancellation functions, invoking them, etc. is not going to work - we should let the handlers return, and the server do its job.I've also added a new contract test to be sure that clients which don't support
restart
capability still have their re-connection code exercised.