feat: Add support for receiving gzip event payloads #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
force-pushed
the
mk/sc-244987/read-limit
branch
from
6c0014a to
7250b3e
Compare
keelerm84
commented
May 20, 2024
config/config.go
Outdated
| @@ -3,6 +3,7 @@ package config | |||
| import ( | |||
| "time" | |||
|
|
|||
| "github.com/alecthomas/units" | |||
There was a problem hiding this comment.
Adding this library because it allows for a nice size type (e.g. 15GiB).
| nonZipBytes := []byte("this is a test") | ||
|
|
||
| reader, _ := NewReader(io.NopCloser(bytes.NewReader(nonZipBytes)), false, 1000) | ||
| payloadReader, _ := reader.(*PayloadReader) |
There was a problem hiding this comment.
Since we aren't returning the PayloadReader type, we have to do this typehint stuff in a couple of places here.
keelerm84
force-pushed
the
mk/sc-244987/read-limit
branch
from
7250b3e to
b793702
Compare
kinyoklion
reviewed
May 22, 2024
cwaldren-ld
reviewed
Jul 10, 2024
internal/util/reader_test.go
Outdated
| } | ||
|
|
||
| func TestZipBombing(t *testing.T) { | ||
| // build a string |
There was a problem hiding this comment.
Probably don't need this comment
keelerm84
force-pushed
the
mk/sc-244987/read-limit
branch
from
7220c19 to
736cf3c
Compare
This allows for better backwards compatibility in that the default option is to not enforce a limit (current behavior). But once a customer does set the value, we can enforce that as a strict > 0 limit.
keelerm84
force-pushed
the
mk/sc-244987/read-limit
branch
from
736cf3c to
f6c29fb
Compare
cwaldren-ld
reviewed
Jul 11, 2024
| @@ -1,6 +1,6 @@ | |||
| module github.com/launchdarkly/ld-relay/v8 | |||
|
|
|||
| go 1.20 | |||
| go 1.21 | |||
There was a problem hiding this comment.
Checking that this change actually requires a bump to the minimum go version?
🤖 I have created a release *beep* *boop* --- ## [8.8.1](v8.8.0...v8.8.1) (2024-07-10) ### Bug Fixes * **deps:** bump supported Go versions to 1.22.5 and 1.21.12 ([#411](#411)) ([02c0a7e](02c0a7e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
**Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/master/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** (Internal: see sc-249267) **Describe the solution you've provided** When the connection URL is specified with a username and password, this was logged in full, for example "Using proxy server at http://my-user-name:my-password@my-proxy-server". This fix redacts any password specified as part of the URL from the logs.
🤖 I have created a release *beep* *boop* --- ## [8.8.2](v8.8.1...v8.8.2) (2024-07-15) ### Bug Fixes * redact password in logs if specified as part of URL ([#413](#413)) ([0471d51](0471d51)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
keelerm84
force-pushed
the
mk/sc-244987/read-limit
branch
from
f276aa3 to
fc9affe
Compare
keelerm84
force-pushed
the
mk/sc-244987/read-limit
branch
from
fc9affe to
0e367ae
Compare
kinyoklion
approved these changes
Jul 25, 2024
keelerm84
pushed a commit
that referenced
this pull request
Jul 25, 2024
🤖 I have created a release *beep* *boop* --- ## [8.9.0](v8.8.2...v8.9.0) (2024-07-25) ### Features * Add new `MaxInboundPayloadSize` configuration to limit event payload sizes ([#364](#364)) ([4803e76](4803e76)) * gzip event payloads before sending to upstream LaunchDarkly APIs ([#364](#364)) ([4803e76](4803e76)) * Support receiving compressed event payloads ([#364](#364)) ([4803e76](4803e76)) ### Bug Fixes * Bump minimum go version to 1.21 ([#364](#364)) ([4803e76](4803e76)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: Support receiving compressed event payloads (#364)
feat: Add new
MaxInboundPayloadSizeconfiguration to limit event payload sizes (#364)feat: gzip event payloads before sending to upstream LaunchDarkly APIs (#364)
fix: Bump minimum go version to 1.21 (#364)
END_COMMIT_OVERRIDE