Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build Docker images for ARMv7 and ARM64v8 architectures #300

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

cwaldren-ld
Copy link
Contributor

@cwaldren-ld cwaldren-ld commented Feb 9, 2024

This commit modifies our goreleaser configuration to achieve two goals:

  1. Produce release binaries for ARM/ARM64 architectures
  2. Produce individual docker images for ARM/ARM64, and produce a final docker manifest referencing those images.

BEGIN_COMMIT_OVERRIDE
feat: build Docker images for ARMv7 and ARM64v8 architectures
END_COMMIT_OVERRIDE

This commit modifies our goreleaser configuration to achieve two goals:
1) Produce release binaries for ARM/ARM64 architectures
2) Produce individual docker images for ARM/ARM64, and produce a final
docker manifest referencing those images.
@cwaldren-ld cwaldren-ld marked this pull request as ready for review February 9, 2024 19:15
@cwaldren-ld cwaldren-ld requested a review from a team February 9, 2024 19:15
- "launchdarkly/ld-relay:latest"
- "launchdarkly/ld-relay:{{ .Version }}-i386"
- "launchdarkly/ld-relay:v{{ .Major }}-i386"
- "launchdarkly/ld-relay:latest-i386"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we make a new branch and forget to remove this bit, that's going to cause problems when we release older versions right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for posterity: discussed offline that it's not optimal that the latest tag flip flops. Have another PR up to fix this.)

@cwaldren-ld cwaldren-ld merged commit 9ea48b5 into v7 Feb 9, 2024
9 checks passed
@cwaldren-ld cwaldren-ld deleted the cw/arm-builds-v7 branch February 9, 2024 22:38
@cwaldren-ld cwaldren-ld changed the title feat(v7): build Docker images for ARMv7 and ARM64v8 architectures feat: build Docker images for ARMv7 and ARM64v8 architectures Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants