feat: build Docker images for ARMv7 and ARM64v8 architectures [v8] #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sc-156011/docker-arm
branch
2 times, most recently
from
12a5129 to
2775d1c
Compare
cwaldren-ld
changed the title
cwaldren-ld
force-pushed
the
cw/sc-156011/docker-arm
branch
from
828b141 to
ca41c4c
Compare
cwaldren-ld
changed the title
cwaldren-ld
force-pushed
the
cw/sc-156011/docker-arm
branch
from
ca41c4c to
463ca91
Compare
louis-launchdarkly
approved these changes
Feb 9, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Feb 9, 2024
🤖 I have created a release *beep* *boop* --- ## [8.3.0](v8.2.3...v8.3.0) (2024-02-09) ### Features * build Docker images for ARMv7 and ARM64v8 architectures [v8] ([#291](#291)) ([a361688](a361688)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies our goreleaser configuration to achieve two goals:
There is some amount of risk involved with this release, namely that the Docker publishing step fails in some way.
I will attempt to mitigate this by modifying the goreleaser image template names with a
-prereleasesuffix, which I'll need to remove before we merge. See public tests here: https://hub.docker.com/r/launchdarkly/ld-relay/tags-alpha1suffix to all images-alpha1suffix, or rinse and repeat with increasing alphas