feat(inline-edit): allow to render IconField
#993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e51f3bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Niznikr
changed the title
IconField
|
Size Change: +706 B (0%) Total Size: 171 kB
ℹ️ View Unchanged
|
apucacao
reviewed
Sep 5, 2023
|
|
||
| const renderIcon = tooltip ? ( | ||
| <Tooltip content={tooltip} targetClassName={styles.iconFieldButton}> | ||
| <IconButton |
There was a problem hiding this comment.
Did you mean to make this into a button? Will users interact with it? (It looks like you can't pass onClick to this specific component for example.)
There was a problem hiding this comment.
Yeah tooltips must have an interactable element as the target/trigger. onClick isn't needed as Tooltip already adds listeners for hover/focus to show the content.
There was a problem hiding this comment.
i was playing in storybook, and it surprised me that i could click on the icon.
apucacao
reviewed
Sep 5, 2023
| @@ -88,6 +84,28 @@ select.formInput { | |||
| border-color: var(--lp-color-border-field-error); | |||
| } | |||
|
|
|||
| .iconField:global(.IconBefore) .formInput { | |||
| padding-left: 3rem; | |||
There was a problem hiding this comment.
should we use the specing tokens here?
There was a problem hiding this comment.
We don't have one for 3rem 😅
| mergeProps(renderInput.props, inputChildren ? {} : inputProps), | ||
| inputChildren && | ||
| Children.map(inputChildren, (child) => | ||
| ['TextField', 'TextArea'].includes(child.type.displayName) |
There was a problem hiding this comment.
Why do we need to reach for the display name here? Is reading displayName this way reliable post-bundling, etc…
There was a problem hiding this comment.
@apucacao, I'm guessing this is to check that, if it's an expected Launchpad-based React element, then we merge its props with the inputProps we need. I don't know anything about bundling effects on this.
There was a problem hiding this comment.
Yeah, I figured.
I was wondering why child.type === TextField wouldn't work. We'd need to import TextField.
There was a problem hiding this comment.
LP component display names aren't minified in the product but just to be safe I can check for the type to match the component itself.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow
InlineEditto renderIconField. AddtooltipandrenderIconLastprops toIconField.Screenshots (if appropriate):