Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): update "new", "active", "inactive", and "status" icons #986

Merged
merged 9 commits into from
Sep 5, 2023

Conversation

jagarnica
Copy link
Contributor

@jagarnica jagarnica commented Sep 1, 2023

Summary

  • Updates the icons: new, active, inactive, status; to a new visual design.

Screenshots (if appropriate):

Screenshot 2023-09-01 at 10 59 38 AM Screenshot 2023-09-01 at 10 59 43 AM Screenshot 2023-09-01 at 10 59 48 AM Screenshot 2023-09-01 at 10 59 53 AM

Testing approaches

Locally running unit, component, and SSR tests.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #213825: Flag status UI updates.

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: 0ecb4a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@launchpad-ui/icons Patch
@launchpad-ui/alert Patch
@launchpad-ui/avatar Patch
@launchpad-ui/banner Patch
@launchpad-ui/button Patch
@launchpad-ui/chip Patch
@launchpad-ui/clipboard Patch
@launchpad-ui/collapsible Patch
@launchpad-ui/drawer Patch
@launchpad-ui/dropdown Patch
@launchpad-ui/filter Patch
@launchpad-ui/form Patch
@launchpad-ui/inline-edit Patch
@launchpad-ui/menu Patch
@launchpad-ui/modal Patch
@launchpad-ui/navigation Patch
@launchpad-ui/pagination Patch
@launchpad-ui/select Patch
@launchpad-ui/snackbar Patch
@launchpad-ui/tag Patch
@launchpad-ui/toast Patch
@launchpad-ui/core Patch
@launchpad-ui/split-button Patch
@launchpad-ui/card Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jagarnica jagarnica changed the title Jagarnica/sc 213825/flag status UI updates feat(icon): update "new", "active", "inactive", and "status" icons Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Size Change: 0 B

Total Size: 171 kB

ℹ️ View Unchanged
Filename Size
packages/alert/dist/index.es.js 1.02 kB
packages/alert/dist/index.js 1.09 kB
packages/alert/dist/style.css 1.03 kB
packages/avatar/dist/index.es.js 1.16 kB
packages/avatar/dist/index.js 1.23 kB
packages/avatar/dist/style.css 466 B
packages/banner/dist/index.es.js 641 B
packages/banner/dist/index.js 711 B
packages/banner/dist/style.css 545 B
packages/button/dist/index.es.js 1.63 kB
packages/button/dist/index.js 1.71 kB
packages/button/dist/style.css 3.71 kB
packages/card/dist/index.es.js 706 B
packages/card/dist/index.js 775 B
packages/card/dist/style.css 754 B
packages/chip/dist/index.es.js 679 B
packages/chip/dist/index.js 749 B
packages/chip/dist/style.css 895 B
packages/clipboard/dist/index.es.js 1.51 kB
packages/clipboard/dist/index.js 1.6 kB
packages/clipboard/dist/style.css 829 B
packages/collapsible/dist/index.es.js 853 B
packages/collapsible/dist/index.js 919 B
packages/collapsible/dist/style.css 94 B
packages/columns/dist/index.es.js 619 B
packages/columns/dist/index.js 692 B
packages/columns/dist/style.css 354 B
packages/core/dist/index.es.js 1.13 kB
packages/core/dist/index.js 1.51 kB
packages/counter/dist/index.es.js 333 B
packages/counter/dist/index.js 396 B
packages/counter/dist/style.css 256 B
packages/data-table/dist/index.es.js 2.47 kB
packages/data-table/dist/index.js 2.53 kB
packages/data-table/dist/style.css 385 B
packages/drawer/dist/index.es.js 1.73 kB
packages/drawer/dist/index.js 2.29 kB
packages/drawer/dist/style.css 570 B
packages/dropdown/dist/index.es.js 1.15 kB
packages/dropdown/dist/index.js 1.21 kB
packages/filter/dist/index.es.js 2.3 kB
packages/filter/dist/index.js 2.37 kB
packages/filter/dist/style.css 1 kB
packages/focus-trap/dist/index.es.js 270 B
packages/focus-trap/dist/index.js 333 B
packages/form/dist/index.es.js 4.01 kB
packages/form/dist/index.js 4.11 kB
packages/form/dist/style.css 2.68 kB
packages/icons/dist/index.es.js 1.28 kB
packages/icons/dist/index.js 1.35 kB
packages/icons/dist/style.css 615 B
packages/inline-edit/dist/index.es.js 1.48 kB
packages/inline-edit/dist/index.js 1.58 kB
packages/inline-edit/dist/style.css 338 B
packages/inline/dist/index.es.js 565 B
packages/inline/dist/index.js 637 B
packages/inline/dist/style.css 299 B
packages/markdown/dist/index.es.js 960 B
packages/markdown/dist/index.js 1.03 kB
packages/markdown/dist/style.css 234 B
packages/menu/dist/index.es.js 3.55 kB
packages/menu/dist/index.js 3.64 kB
packages/menu/dist/style.css 1.22 kB
packages/modal/dist/index.es.js 3.03 kB
packages/modal/dist/index.js 3.58 kB
packages/modal/dist/style.css 1.03 kB
packages/navigation/dist/index.es.js 2.79 kB
packages/navigation/dist/index.js 2.86 kB
packages/navigation/dist/style.css 1.25 kB
packages/overlay/dist/index.es.js 1 kB
packages/overlay/dist/index.js 1.06 kB
packages/pagination/dist/index.es.js 1.18 kB
packages/pagination/dist/index.js 1.26 kB
packages/pagination/dist/style.css 356 B
packages/popover/dist/index.es.js 3.07 kB
packages/popover/dist/index.js 3.58 kB
packages/popover/dist/style.css 629 B
packages/portal/dist/index.es.js 393 B
packages/portal/dist/index.js 453 B
packages/progress-bubbles/dist/index.es.js 1.76 kB
packages/progress-bubbles/dist/index.js 1.83 kB
packages/progress-bubbles/dist/style.css 961 B
packages/progress/dist/index.es.js 1.02 kB
packages/progress/dist/index.js 1.09 kB
packages/progress/dist/style.css 278 B
packages/select/dist/index.es.js 5.91 kB
packages/select/dist/index.js 5.99 kB
packages/select/dist/style.css 1.34 kB
packages/slider/dist/index.es.js 579 B
packages/slider/dist/index.js 644 B
packages/slider/dist/style.css 672 B
packages/snackbar/dist/index.es.js 1.18 kB
packages/snackbar/dist/index.js 1.73 kB
packages/snackbar/dist/style.css 580 B
packages/split-button/dist/index.es.js 887 B
packages/split-button/dist/index.js 959 B
packages/split-button/dist/style.css 495 B
packages/stack/dist/index.es.js 494 B
packages/stack/dist/index.js 565 B
packages/stack/dist/style.css 226 B
packages/tab-list/dist/index.es.js 737 B
packages/tab-list/dist/index.js 809 B
packages/tab-list/dist/style.css 455 B
packages/table/dist/index.es.js 1.02 kB
packages/table/dist/index.js 1.1 kB
packages/table/dist/style.css 905 B
packages/tag/dist/index.es.js 2.85 kB
packages/tag/dist/index.js 2.92 kB
packages/tag/dist/style.css 945 B
packages/toast/dist/index.es.js 979 B
packages/toast/dist/index.js 1.53 kB
packages/toast/dist/style.css 544 B
packages/toggle/dist/index.es.js 764 B
packages/toggle/dist/index.js 844 B
packages/toggle/dist/style.css 1.52 kB
packages/tokens/dist/index.css 1.48 kB
packages/tokens/dist/index.es.js 2.04 kB
packages/tokens/dist/index.js 7.49 kB
packages/tokens/dist/media-queries.css 112 B
packages/tokens/dist/themes.css 1.28 kB
packages/tooltip/dist/index.es.js 517 B
packages/tooltip/dist/index.js 591 B
packages/tooltip/dist/style.css 366 B
packages/vars/dist/index.es.js 1.63 kB
packages/vars/dist/index.js 1.7 kB

compressed-size-action

@jagarnica jagarnica marked this pull request as ready for review September 1, 2023 18:09
@@ -0,0 +1,5 @@
---
'@launchpad-ui/icons': minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'@launchpad-ui/icons': minor
'@launchpad-ui/icons': patch

Non-breaking 0.x versioning changes

Copy link
Contributor

@Niznikr Niznikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lockfile changes seem undesired. What version of pnpm are you using?

@jagarnica
Copy link
Contributor Author

The lockfile changes seem undesired. What version of pnpm are you using?

I was using an earlier version at first but I then upgraded to 8.7.1. I was on v7 but I had some issues with it

@Niznikr
Copy link
Contributor

Niznikr commented Sep 5, 2023

Could you revert the changes to the lockfile?

@jagarnica
Copy link
Contributor Author

Could you revert the changes to the lockfile?

Absolutely! I think I found how I caused that. I just reverted those changes now.

@jagarnica jagarnica requested a review from Niznikr September 5, 2023 18:19
@jagarnica jagarnica merged commit 21ef37b into main Sep 5, 2023
15 checks passed
@jagarnica jagarnica deleted the jagarnica/sc-213825/flag-status-ui-updates branch September 5, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants