refactor(button): convert to css modules #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 32efa64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
apucacao
reviewed
Oct 6, 2023
| margin-left: -0.1rem; | ||
| } | ||
|
|
||
| .SplitButtonDrop:global([class*='_Button--small_']) { |
There was a problem hiding this comment.
What are those selectors with underscores?
There was a problem hiding this comment.
Targeting parent selectors whose class names get hashed from css modules
|
Size Change: +781 B (0%) Total Size: 168 kB
ℹ️ View Unchanged
|
apucacao
approved these changes
Oct 6, 2023
Niznikr
added a commit
that referenced
this pull request
Nov 17, 2023
* chore: enter prerelease mode * feat(tokens)!: move color primitives to themes.css (#1020) * feat(tokens)!: move color primitives to themes.css * feat(tokens): build with TS * feat(tokens): generate types * feat(tokens): transform dark values * chore: add changeset * fix: update value to hsl * chore: fix lockfile * refactor(button): convert to css modules (#1030) * refactor(button): convert to css modules * chore: add changeset * fix: disabled icon * fix: test * refactor(tokens)!: update color primitives and aliases for product refresh (#1029) * feat(tokens)!: update color primitives * feat(tokens): update color aliases * chore: add changeset * fix: add opacity to aliases * feat: test wcag 2.2 * feat(tokens): add new aliases * refactor: update button styles * chore: update tokens story * refactor: simplify contract * chore: merge branch 'main' into release/color-refresh (#1036) * chore(deps): update all non-major dependencies (#1032) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * refactor!: use base 16 font size (#1033) * refactor: use base 16 font size * chore: add changeset * fix: ve styles * fix: inline style * chore: version packages (#1034) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(deps): update nrwl/nx-set-shas action to v4 (#1035) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update initialVersions --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: pd-sa-github-launchpad-ui <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat(tokens): add typography tokens (#1037) * feat(tokens): add typography tokens * refactor: use vars * chore: add changeset * feat: add display * chore: version packages (alpha) (#1028) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: refresh menu component (#1043) * feat: refresh menu styles * chore: use medium radius on popovers * chore: update menu stories * chore: add changeset * fix: update custom css so tests don't fail * refactor(menu): use CSS modules (#1046) * refactor(menu): use css modules * chore: add changeset * chore: fix classes * chore: version packages (alpha) (#1045) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: merge branch 'main' into release/color-refresh (#1049) * chore(deps): update all non-major dependencies (#1032) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * refactor!: use base 16 font size (#1033) * refactor: use base 16 font size * chore: add changeset * fix: ve styles * fix: inline style * chore: version packages (#1034) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(deps): update nrwl/nx-set-shas action to v4 (#1035) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update all non-major dependencies (#1039) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency lint-staged to v15 (#1040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(tokens, icons, alert): add new tokens and icons (#1038) * feat(tokens, icons): add new tokens and icons * feat(tokens, icons): update token names and stories, update icon svgs * feat(tokens, icons): update changelog * feat(icons): update css to use gradient tokens * feat(alert): update CSS to use new gradient tokens * Update packages/tokens/src/color-aliases.yaml Co-authored-by: Robert Niznik <[email protected]> --------- Co-authored-by: Robert Niznik <[email protected]> * chore: version packages (#1041) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat(tokens): add primitive size tokens (#1031) * feat: add primitive size tokens * fix: use size variable tokens in storybook * fix: add whitespace at bottom of size token file * chore: update sizes to use base 16 * chore: use sizing tokens in borders * fix: add 3 and 1200 sizes * chore: update fonts to use size tokens * chore: use size tokens in spacing * chore: se size tokens in viewport * fix: space between constants in size story * chore: add changeset * fix: make slice const name more explicit * fix: use size 1 for border 200 Co-authored-by: Robert Niznik <[email protected]> --------- Co-authored-by: Robert Niznik <[email protected]> * feat: add building and door icons (#1048) * feat: adds building icons * feat: add door-exit icon * chore: add changeset * chore: version packages (#1042) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: fix token build * chore: update initialVersions * chore: fix size story --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: pd-sa-github-launchpad-ui <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Valerie Roske <[email protected]> Co-authored-by: Matthew Ferry <[email protected]> * fix: correct tokens version (#1051) * chore: version packages (alpha) (#1050) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix(tokens): keep css color keywords (#1060) * fix(tokens): keep css color keywords * chore: bump ts-node * chore: add changeset * feat: Update color steps from 9 to 12 (#1068) * feat: add 3 new grays and black and white to 12 * feat: purple remap from 9 to 12 steps * fix: update flair base dark color * feat: pink remap from 9 to 12 steps * feat: cyan remap from 9 to 12 steps * feat: yellow remap from 9 to 12 steps * fix: adjust yellow 300 chroma * feat: blue remap from 9 to 12 steps * fix: reorder white and black tokens in ascending order * feat: red map 9 to 12 steps * feat: green map 9 to 12 steps * feat: yellow map 9 to 12 steps * fix: a11y tertiary text in dark * fix: a11y button hover state * fix: update chip tokens for a11y * fix: update fills for info and error in dark * chore: add changeset * chore: merge branch 'main' into release/color-refresh (#1073) * chore(deps): update all non-major dependencies (#1032) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * refactor!: use base 16 font size (#1033) * refactor: use base 16 font size * chore: add changeset * fix: ve styles * fix: inline style * chore: version packages (#1034) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(deps): update nrwl/nx-set-shas action to v4 (#1035) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update all non-major dependencies (#1039) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency lint-staged to v15 (#1040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(tokens, icons, alert): add new tokens and icons (#1038) * feat(tokens, icons): add new tokens and icons * feat(tokens, icons): update token names and stories, update icon svgs * feat(tokens, icons): update changelog * feat(icons): update css to use gradient tokens * feat(alert): update CSS to use new gradient tokens * Update packages/tokens/src/color-aliases.yaml Co-authored-by: Robert Niznik <[email protected]> --------- Co-authored-by: Robert Niznik <[email protected]> * chore: version packages (#1041) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat(tokens): add primitive size tokens (#1031) * feat: add primitive size tokens * fix: use size variable tokens in storybook * fix: add whitespace at bottom of size token file * chore: update sizes to use base 16 * chore: use sizing tokens in borders * fix: add 3 and 1200 sizes * chore: update fonts to use size tokens * chore: use size tokens in spacing * chore: se size tokens in viewport * fix: space between constants in size story * chore: add changeset * fix: make slice const name more explicit * fix: use size 1 for border 200 Co-authored-by: Robert Niznik <[email protected]> --------- Co-authored-by: Robert Niznik <[email protected]> * feat: add building and door icons (#1048) * feat: adds building icons * feat: add door-exit icon * chore: add changeset * chore: version packages (#1042) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(deps): update commitlint monorepo to v18 (#1053) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency nx to v17 (#1054) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update all non-major dependencies (#1052) * fix(deps): update all non-major dependencies * chore: add changeset --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Robb Niznik <[email protected]> * chore(deps): lock file maintenance (#1056) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/setup-node action to v4 (#1058) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency node to v20 (#1059) * chore(deps): update dependency node to v20 * ci: use node 20 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Robb Niznik <[email protected]> * docs: add getting started page to SB (#1062) * docs: add getting started page to SB * chore: clean up url * feat(icons): org settings icons and updates (#1063) * feat: add new org settings icons * chore: add changeset * fix: add person-off back * chore: version packages (#1055) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(deps): update all non-major dependencies (#1065) * chore(deps): update all non-major dependencies * fix: pin style-dictionary --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Robb Niznik <[email protected]> * chore(deps): lock file maintenance (#1069) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: add diamond and diamond-outline icons (#1070) * chore: version packages (#1071) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(deps): update dependency html-react-parser to v5 (#1072) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update initialVersions * fix: adjust build script --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: pd-sa-github-launchpad-ui <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Valerie Roske <[email protected]> Co-authored-by: Matthew Ferry <[email protected]> * chore: version packages (alpha) (#1061) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: move primitives back to index.css * chore: exit prerelease * fix: update box colors --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: pd-sa-github-launchpad-ui <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Ferry <[email protected]> Co-authored-by: Valerie Roske <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to tweak some variables button uses for the refresh. So to allow us to ff those styles we need to convert them to css modules.