Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(icons)!: update all icons for IA visual design and icon refresh #1025

Merged
merged 4 commits into from
Oct 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions .changeset/pre.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
{
"mode": "exit",
"tag": "alpha",
"initialVersions": {
"@launchpad-ui/remix": "0.0.1",
"@launchpad-ui/alert": "0.7.33",
"@launchpad-ui/avatar": "0.5.15",
"@launchpad-ui/banner": "0.9.32",
"@launchpad-ui/button": "0.10.8",
"@launchpad-ui/card": "0.1.10",
"@launchpad-ui/chip": "0.8.15",
"@launchpad-ui/clipboard": "0.10.26",
"@launchpad-ui/collapsible": "0.1.28",
"@launchpad-ui/columns": "0.1.5",
"@launchpad-ui/core": "0.45.7",
"@launchpad-ui/counter": "0.3.33",
"@launchpad-ui/data-table": "0.1.4",
"@launchpad-ui/drawer": "0.4.27",
"@launchpad-ui/dropdown": "0.6.71",
"@launchpad-ui/filter": "0.5.52",
"@launchpad-ui/focus-trap": "0.1.11",
"@launchpad-ui/form": "0.9.16",
"@launchpad-ui/icons": "0.12.6",
"@launchpad-ui/inline": "0.1.5",
"@launchpad-ui/inline-edit": "0.1.15",
"@launchpad-ui/markdown": "0.4.21",
"@launchpad-ui/menu": "0.11.19",
"@launchpad-ui/modal": "0.16.22",
"@launchpad-ui/navigation": "0.11.43",
"@launchpad-ui/overlay": "0.3.29",
"@launchpad-ui/pagination": "0.3.75",
"@launchpad-ui/popover": "0.10.16",
"@launchpad-ui/portal": "0.1.4",
"@launchpad-ui/progress": "0.5.30",
"@launchpad-ui/progress-bubbles": "0.6.25",
"@launchpad-ui/select": "0.3.24",
"@launchpad-ui/slider": "0.4.11",
"@launchpad-ui/snackbar": "0.3.71",
"@launchpad-ui/split-button": "0.8.18",
"@launchpad-ui/stack": "0.1.5",
"@launchpad-ui/tab-list": "0.4.37",
"@launchpad-ui/table": "0.5.12",
"@launchpad-ui/tag": "0.2.23",
"@launchpad-ui/toast": "0.2.68",
"@launchpad-ui/toggle": "0.6.9",
"@launchpad-ui/tokens": "0.7.1",
"@launchpad-ui/tooltip": "0.7.26",
"@launchpad-ui/types": "0.1.0",
"@launchpad-ui/vars": "0.2.2"
},
"changesets": ["smooth-berries-nail", "lovely-suns-smile"]
}
6 changes: 6 additions & 0 deletions .changeset/smooth-berries-nail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@launchpad-ui/icons': minor
'@launchpad-ui/core': minor
---

[Icons] Complete redraw of all icons, removal of deprecated icons, addition of new icons, and rename keys for consistency
2 changes: 1 addition & 1 deletion apps/remix/app/routes/components.icon-button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ import { IconButton } from '@launchpad-ui/core';
import { Icon } from '@launchpad-ui/icons';

export default function Index() {
return <IconButton aria-label="Close icon" icon={<Icon name="close" size="medium" />} />;
return <IconButton aria-label="Close icon" icon={<Icon name="cancel" size="medium" />} />;
}
8 changes: 8 additions & 0 deletions packages/alert/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# @launchpad-ui/alert

## 0.7.34-alpha.0

### Patch Changes

- Updated dependencies [[`ba2a5138`](https://github.com/launchdarkly/launchpad-ui/commit/ba2a5138c9ff43b17654812437025ba9671d4923)]:
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]

## 0.7.33

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/alert/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@launchpad-ui/alert",
"version": "0.7.33",
"version": "0.7.34-alpha.0",
"status": "beta",
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/alert/src/Alert.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ const Alert = ({
aria-label="Close this alert."
size="small"
className={styles['Alert-close']}
icon={<Icon name="close" size="small" />}
icon={<Icon name="cancel" size="small" />}
kind="close"
onClick={() => setDismissedState(true)}
data-test-id={`${testId}-dismiss-button`}
Expand Down
7 changes: 7 additions & 0 deletions packages/avatar/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @launchpad-ui/avatar

## 0.5.16-alpha.0

### Patch Changes

- Updated dependencies [[`ba2a5138`](https://github.com/launchdarkly/launchpad-ui/commit/ba2a5138c9ff43b17654812437025ba9671d4923)]:
- @launchpad-ui/[email protected]

## 0.5.15

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/avatar/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@launchpad-ui/avatar",
"version": "0.5.15",
"version": "0.5.16-alpha.0",
"status": "beta",
"publishConfig": {
"access": "public"
Expand Down
8 changes: 8 additions & 0 deletions packages/banner/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# @launchpad-ui/banner

## 0.9.33-alpha.0

### Patch Changes

- Updated dependencies [[`ba2a5138`](https://github.com/launchdarkly/launchpad-ui/commit/ba2a5138c9ff43b17654812437025ba9671d4923)]:
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]

## 0.9.32

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/banner/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@launchpad-ui/banner",
"version": "0.9.32",
"version": "0.9.33-alpha.0",
"status": "beta",
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/banner/src/Banner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const Banner = ({
{!!onDismiss && (
<IconButton
aria-label="Close banner"
icon={<Icon name="close" size="small" />}
icon={<Icon name="cancel" size="small" />}
size="small"
onClick={onDismiss}
kind="close"
Expand Down
7 changes: 7 additions & 0 deletions packages/button/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @launchpad-ui/button

## 0.10.9-alpha.0

### Patch Changes

- Updated dependencies [[`ba2a5138`](https://github.com/launchdarkly/launchpad-ui/commit/ba2a5138c9ff43b17654812437025ba9671d4923)]:
- @launchpad-ui/[email protected]

## 0.10.8

### Patch Changes
Expand Down
12 changes: 6 additions & 6 deletions packages/button/__tests__/IconButton.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ import { IconButton } from '../src';

describe('Button', () => {
it('renders', () => {
render(<IconButton aria-label="Close" icon={<Icon name="close" />} />);
render(<IconButton aria-label="Close" icon={<Icon name="cancel" />} />);
expect(screen.getByRole('button', { name: 'Close' })).toBeInTheDocument();
});

it('can render as a slotted link', () => {
const { container } = render(
<IconButton aria-label="Close" icon={<Icon name="close" />} asChild>
<IconButton aria-label="Close" icon={<Icon name="cancel" />} asChild>
<a href="/">Test</a>
</IconButton>
);
Expand All @@ -23,7 +23,7 @@ describe('Button', () => {
it('handles clicks', async () => {
const spy = vi.fn();
const user = userEvent.setup();
render(<IconButton aria-label="Close" icon={<Icon name="close" />} onClick={spy} />);
render(<IconButton aria-label="Close" icon={<Icon name="cancel" />} onClick={spy} />);

await user.click(screen.getByRole('button', { name: 'Close' }));

Expand All @@ -34,7 +34,7 @@ describe('Button', () => {
const spy = vi.fn();
const user = userEvent.setup();
render(
<IconButton aria-label="Close" icon={<Icon name="close" />} onClick={spy} asChild>
<IconButton aria-label="Close" icon={<Icon name="cancel" />} onClick={spy} asChild>
<a href="/">Test</a>
</IconButton>
);
Expand All @@ -46,14 +46,14 @@ describe('Button', () => {

it('is focusable', async () => {
const user = userEvent.setup();
render(<IconButton aria-label="Close" icon={<Icon name="close" />} />);
render(<IconButton aria-label="Close" icon={<Icon name="cancel" />} />);

await user.tab();
expect(screen.getByRole('button', { name: 'Close' })).toHaveFocus();
});

it('can render an icon', async () => {
const { container } = render(<IconButton aria-label="Close" icon={<Icon name="close" />} />);
const { container } = render(<IconButton aria-label="Close" icon={<Icon name="cancel" />} />);
// eslint-disable-next-line testing-library/no-container, testing-library/no-node-access
expect(container.querySelector('svg')).not.toBeNull();
});
Expand Down
2 changes: 1 addition & 1 deletion packages/button/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@launchpad-ui/button",
"version": "0.10.8",
"version": "0.10.9-alpha.0",
"status": "beta",
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/button/stories/Button.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export const WithIcon: Story = {
};

export const WithIconPrimary: Story = {
args: { children: 'With icon', icon: <Icon name="expand-more" />, kind: 'primary' },
args: { children: 'With icon', icon: <Icon name="chevron-down" />, kind: 'primary' },
};

export const BigButtonWithIcon: Story = {
Expand Down
7 changes: 7 additions & 0 deletions packages/card/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @launchpad-ui/card

## 0.1.11-alpha.0

### Patch Changes

- Updated dependencies []:
- @launchpad-ui/[email protected]

## 0.1.10

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/card/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@launchpad-ui/card",
"version": "0.1.10",
"version": "0.1.11-alpha.0",
"status": "alpha",
"publishConfig": {
"access": "public"
Expand Down
7 changes: 7 additions & 0 deletions packages/chip/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @launchpad-ui/chip

## 0.8.16-alpha.0

### Patch Changes

- Updated dependencies [[`ba2a5138`](https://github.com/launchdarkly/launchpad-ui/commit/ba2a5138c9ff43b17654812437025ba9671d4923)]:
- @launchpad-ui/[email protected]

## 0.8.15

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/chip/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@launchpad-ui/chip",
"version": "0.8.15",
"version": "0.8.16-alpha.0",
"status": "beta",
"publishConfig": {
"access": "public"
Expand Down
7 changes: 7 additions & 0 deletions packages/clipboard/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @launchpad-ui/clipboard

## 0.10.27-alpha.0

### Patch Changes

- Updated dependencies [[`ba2a5138`](https://github.com/launchdarkly/launchpad-ui/commit/ba2a5138c9ff43b17654812437025ba9671d4923)]:
- @launchpad-ui/[email protected]

## 0.10.26

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/clipboard/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@launchpad-ui/clipboard",
"version": "0.10.26",
"version": "0.10.27-alpha.0",
"status": "beta",
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/clipboard/src/CopyCodeButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const CopyCodeButton = forwardRef<HTMLButtonElement, CopyCodeButtonProps>(
{children}
{(kind === 'basic' || kind === 'minimal') && (
<Icon
name="clipboard-copy"
name="copy-clipboard"
className={cx(styles['CopyCodeButton--icon'])}
aria-hidden="true"
size="small"
Expand Down
8 changes: 8 additions & 0 deletions packages/collapsible/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# @launchpad-ui/collapsible

## 0.1.29-alpha.0

### Patch Changes

- Updated dependencies [[`ba2a5138`](https://github.com/launchdarkly/launchpad-ui/commit/ba2a5138c9ff43b17654812437025ba9671d4923)]:
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]

## 0.1.28

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/collapsible/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@launchpad-ui/collapsible",
"version": "0.1.28",
"version": "0.1.29-alpha.0",
"status": "alpha",
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/collapsible/src/Collapsible.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const Collapsible = (props: CollapsibleProps) => {

const label = typeof props.label === 'string' ? props.label : props.label(isOpen);

const icon = isOpen ? <Icon name="expand-less" /> : <Icon name="expand-more" />;
const icon = isOpen ? <Icon name="chevron-up" /> : <Icon name="chevron-down" />;

const renderedTrigger = trigger({
label,
Expand Down
32 changes: 32 additions & 0 deletions packages/core/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,37 @@
# @launchpad-ui/core

## 0.46.0-alpha.0

### Minor Changes

- [#1016](https://github.com/launchdarkly/launchpad-ui/pull/1016) [`ba2a5138`](https://github.com/launchdarkly/launchpad-ui/commit/ba2a5138c9ff43b17654812437025ba9671d4923) Thanks [@matthewferry](https://github.com/matthewferry)! - [Icons] Complete redraw of all icons, removal of deprecated icons, addition of new icons, and rename keys for consistency

### Patch Changes

- Updated dependencies []:
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]

## 0.45.7

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@launchpad-ui/core",
"version": "0.45.7",
"version": "0.46.0-alpha.0",
"status": "beta",
"publishConfig": {
"access": "public"
Expand Down
8 changes: 8 additions & 0 deletions packages/drawer/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# @launchpad-ui/drawer

## 0.4.28-alpha.0

### Patch Changes

- Updated dependencies [[`ba2a5138`](https://github.com/launchdarkly/launchpad-ui/commit/ba2a5138c9ff43b17654812437025ba9671d4923)]:
- @launchpad-ui/[email protected]
- @launchpad-ui/[email protected]

## 0.4.27

### Patch Changes
Expand Down
Loading
Loading