-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tokens): add new "primary-flair" color tokens #1009
Merged
pheggeseth
merged 2 commits into
main
from
pheggeseth/feat(tokens)--add-color-bg-product-flair-token
Sep 22, 2023
Merged
feat(tokens): add new "primary-flair" color tokens #1009
pheggeseth
merged 2 commits into
main
from
pheggeseth/feat(tokens)--add-color-bg-product-flair-token
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a803947 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Niznikr
reviewed
Sep 22, 2023
Size Change: +215 B (0%) Total Size: 172 kB
ℹ️ View Unchanged
|
Niznikr
approved these changes
Sep 22, 2023
erangeles
approved these changes
Sep 22, 2023
pheggeseth
deleted the
pheggeseth/feat(tokens)--add-color-bg-product-flair-token
branch
September 22, 2023 19:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds new color tokens for "primary-flair" (purple) to be used in the releases view:
--lp-color-bg-ui-primary-flair
: purple 200 on light, purple 900 on dark--lp-color-border-ui-primary-flair
: purple 300 on light, purple 600 on dark--lp-color-fill-ui-primary-flair
: purple 500 on light, purple 300 on darkScreenshots (if appropriate):
Testing approaches