fix: pass parsed versionKey to Tracker #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
changed the title
cwaldren-ld
commented
Dec 5, 2024
| @@ -76,13 +76,13 @@ func (c *Client) Config( | |||
| // empty object.) | |||
| if result.Type() != ldvalue.ObjectType { | |||
| c.logConfigWarning(key, "unmarshalling failed, expected JSON object but got %s", result.Type().String()) | |||
| return defaultValue, newTracker(key, c.sdk, &defaultValue, context, c.logger) | |||
There was a problem hiding this comment.
I think we agreed on "empty string for version key in default value".
kinyoklion
approved these changes
Dec 5, 2024
cwaldren-ld
pushed a commit
that referenced
this pull request
Dec 5, 2024
🤖 I have created a release *beep* *boop* --- ## 0.1.0 (2024-12-05) ### Features * pass tracker's config into TrackRequest ([#210](#210)) ([8321db6](8321db6)) ### Bug Fixes * pass parsed versionKey to Tracker ([#211](#211)) ([215116a](215116a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AI client wasn't passing the parsed
_ldMeta.versionKeyinto newly createdTrackers. The tests didn't catch it because the default value of strings are"", and that's what the tests asserted against.I've updated the tests to pass in a non-default string to make sure it is being plumbed through.